New issue
Advanced search Search tips

Issue 601064 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Prevent appcache in iframes

Project Member Reported by jakearchibald@chromium.org, Apr 6 2016

Issue description

https://output.jsbin.com/medoke/quiet - here I create a series of iframe with random urls pointing to https://gabrielecirulli.github.io/2048/

This floods the master entry part of appcache, making updates to 2048 much larger, forever.

This attack doesn't work in Safari, I'm guessing the prevent appcache in iframes (maybe cross-origin only).

We should do the same.
 
Status: Available (was: Untriaged)
What does the spec have to say about the expected behavior, does it say anything about preventing xorigin iframes from establishing appcaches?

Removing that function could easily break existing uses.

A reasonable constraint on the number of master entries might be a safer way to go.
Firefox's behavior matches chrome's, it caches the master entries too.
Labels: Hotlist-Interop
I reckon Safari is (wilfully) breaking spec here, but it does prevent the attack.
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 14 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)
I think google drive and google docs rely on being able to establish appcaches xorigin to pull down new docs.

The safest change i can think of is to put a reasonable limit on the number of master entries, when n+1 comes around, silently refuse to add it. We could add uma stats to get an idea of how many master entries there typically are as the basis for the reasonable limit?
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 18 2018

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by jsb...@chromium.org, Apr 30 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Owner: pwnall@chromium.org
Status: Assigned (was: Available)
UMA metric to see if we can remove this?
Cc: pwnall@chromium.org
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment