New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601063 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 4
Cc:
perezju@chromium.org
█ picksi@chromium.org
sullivan@chromium.org
█ aiolos@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

highlight=commit_ID feature request for chromeperf dashboard

Project Member Reported by primiano@chromium.org, Apr 6 2016 
Often I find myself in the current scenario:
- I am looking for a regression.
- I open a bunch of charts in the same page to investigate.
- I manually look for a given commit (or range) in each benchmark

Would be great if I could append a ?highlight=12345 (or 12345:67890 for range) to the chromeperf URL and that would graphically annotate with a vertical bar or similar that commit in all the benchmarks I'm looking at.

Comment 1 by qyears...@chromium.org, Apr 22 2016 

This sounds like a GoodFirstBug.

There is an example of adding a vertical bar to a Flot chart here:
https://github.com/catapult-project/catapult/blob/a8a6fb7ea/dashboard/dashboard/static/debug_alert.html#L61

For this feature, some code would likely be added in elements/chart-container.html. 

This issue may be more likely to have people look at it if it's filed at:
https://github.com/catapult-project/catapult/issues

Comment 2 by sullivan@chromium.org, Apr 22 2016

Cc: aiolos@chromium.org

Comment 3 by benhenry@google.com, Feb 2 2017

Components: Speed>Dashboard
Labels: -Performance-Dashboard

Comment 4 by benjhayden@chromium.org, Oct 4

Status: Fixed (was: Untriaged)
IIRC, this was added to the V1 UI. I'll file a new bug to add it to V2.
►

Sign in to add a comment