The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad3ee42510afda09e00cb73c694bfa4626980d1d

commit ad3ee42510afda09e00cb73c694bfa4626980d1d
Author: wnwen <wnwen@chromium.org>
Date: Wed Dec 14 19:11:14 2016

Android: Switch to thread pool executor.

Switches BackgroundSyncLauncher to the thread pool executor and add
comments explaining why AsyncTask is necessary.

BUG=601053

Review-Url: https://codereview.chromium.org/2562643004
Cr-Commit-Position: refs/heads/master@{#438573}

[modify] https://crrev.com/ad3ee42510afda09e00cb73c694bfa4626980d1d/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java
[modify] https://crrev.com/ad3ee42510afda09e00cb73c694bfa4626980d1d/chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java
[modify] https://crrev.com/ad3ee42510afda09e00cb73c694bfa4626980d1d/chrome/browser/android/background_sync_launcher_android.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0be43188cb2345a40a73205bb65dd4164aa9d259

commit 0be43188cb2345a40a73205bb65dd4164aa9d259
Author: wnwen <wnwen@chromium.org>
Date: Wed Dec 14 22:01:36 2016

Revert of Android: Switch to thread pool executor (patchset #7 id:120001 of https://codereview.chromium.org/2562643004/ )

Reason for revert:
BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline fails.

Original issue's description:
> Android: Switch to thread pool executor.
>
> Switches BackgroundSyncLauncher to the thread pool executor and add
> comments explaining why AsyncTask is necessary.
>
> BUG=601053
>
> Committed: https://crrev.com/ad3ee42510afda09e00cb73c694bfa4626980d1d
> Cr-Commit-Position: refs/heads/master@{#438573}

TBR=iclelland@chromium.org,mariakhomenko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601053

Review-Url: https://codereview.chromium.org/2580503002
Cr-Commit-Position: refs/heads/master@{#438645}

[modify] https://crrev.com/0be43188cb2345a40a73205bb65dd4164aa9d259/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java
[modify] https://crrev.com/0be43188cb2345a40a73205bb65dd4164aa9d259/chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java
[modify] https://crrev.com/0be43188cb2345a40a73205bb65dd4164aa9d259/chrome/browser/android/background_sync_launcher_android.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80528b6a6acce7e1cc5829aaae876fb608aabb18

commit 80528b6a6acce7e1cc5829aaae876fb608aabb18
Author: wnwen <wnwen@chromium.org>
Date: Mon Dec 19 18:49:05 2016

Reland "Android: Switch to thread pool executor"

Original CL: http://crrev.com/2562643004

Fixes BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline.

TBR=mariakhomenko@chromium.org
BUG=601053, 674293 

Review-Url: https://codereview.chromium.org/2580523002
Cr-Commit-Position: refs/heads/master@{#439511}

[modify] https://crrev.com/80528b6a6acce7e1cc5829aaae876fb608aabb18/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java
[modify] https://crrev.com/80528b6a6acce7e1cc5829aaae876fb608aabb18/chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java
[modify] https://crrev.com/80528b6a6acce7e1cc5829aaae876fb608aabb18/chrome/browser/android/background_sync_launcher_android.cc

Is there more work that needs to be done here?

Unfortunately yes, that was only one of the 40+ instances that should be examined and considered for moving to multi-threaded async task queuing. This just fell by the wayside.

Will circle back to this at some point, but we are looking at systemic approaches on fixing java threading.

See  issue 542151 .

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot