Issue metadata
Sign in to add a comment
|
Regression: Chrome::// pages have a very small fontsize |
||||||||||||||||||||||
Issue descriptionVersion: Version 51.0.2701.0 canary (64-bit) <b>OS: <please tell me it's not XP></b> What steps will reproduce the problem? (1) go to chrome://settings/ (2) take a look at the fontsize (3) What is the expected output? What do you see instead? The font is very small. Seems to be a regression. A Screenshot is attached: Left Stable, right Canary. Please use labels and text to provide additional information.
,
Apr 6 2016
Repros on Windows too. Processing of text_defaults.css appears to be broken. Chrome 49 has body font-family: 'Segoe UI', Tahoma, sans-serif Canary 51 has body font-family: '
,
Apr 6 2016
,
Apr 6 2016
+dschuyler. Apologies if I'm horribly mistaken.
,
Apr 6 2016
Marking this with RB label as this is a latest regression issue on M51 ToT builds.
,
Apr 6 2016
,
Apr 6 2016
(comment copied from bug 600927 ) Hi, Please check the this page within chrome: chrome://resources/css/text_defaults.css That page should be setting the font. If that page is messed up in some way, please let me know.
,
Apr 6 2016
,
Apr 6 2016
Re: #8 Yes, that CSS has HTML-encoding of the quotes surrounding the font-family attribute, making that attribute invalid and thus disabling the style rule.
,
Apr 6 2016
,
Apr 6 2016
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c53b2ab34cde861beab8e9a88ba71414d410c7e commit 3c53b2ab34cde861beab8e9a88ba71414d410c7e Author: dschuyler <dschuyler@chromium.org> Date: Thu Apr 07 01:06:48 2016 [Template expressions] font-family needs to be i18nRaw for mac/win quoted fonts Font-family css may now have quoted font names. BUG= 601051 Review URL: https://codereview.chromium.org/1868593003 Cr-Commit-Position: refs/heads/master@{#385609} [modify] https://crrev.com/3c53b2ab34cde861beab8e9a88ba71414d410c7e/ui/webui/resources/css/text_defaults.css [modify] https://crrev.com/3c53b2ab34cde861beab8e9a88ba71414d410c7e/ui/webui/resources/css/text_defaults_md.css
,
Apr 7 2016
Removing Needs-Bisect label as CL is already posted by bugdroid.
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d632b7693d284d21a7e6314f932be23767c33386 commit d632b7693d284d21a7e6314f932be23767c33386 Author: dbeam <dbeam@chromium.org> Date: Thu Apr 07 21:39:43 2016 WebUI: add functional test for text_defaults.css R=dschuyler@chromium.org,sky@chromium.org BUG= 601051 NOTRY=true # see patchset 1 Review URL: https://codereview.chromium.org/1863963004 Cr-Commit-Position: refs/heads/master@{#385882} [modify] https://crrev.com/d632b7693d284d21a7e6314f932be23767c33386/chrome/chrome_tests.gypi [modify] https://crrev.com/d632b7693d284d21a7e6314f932be23767c33386/chrome/test/base/web_ui_browser_test.cc [add] https://crrev.com/d632b7693d284d21a7e6314f932be23767c33386/chrome/test/data/webui/text_defaults_browsertest.js
,
Apr 7 2016
,
Apr 12 2016
Issue 601679 has been merged into this issue.
,
Apr 13 2016
Issue 601159 has been merged into this issue.
,
May 26 2016
,
May 26 2016
I think this whatever this issue is should go into a new bug, rather than append to this original issue that was fixed. r2galeano@ - please file a new bug with a description of the problem and steps to reproduce. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Apr 6 2016