OneClickSigninSyncStarter runs some sync init code multiple times in the new signin flow |
||
Issue descriptionUnder the new signin flow, OneClickSigninSyncStarter has a longer lifetime since it's not deleting itself until after the sync confirmation dialog is closed. The result of this is that it receives the OnAccountAddedToCookie notification from the SigninTracker multiple times. This can cause crashes or the dialog to be shown, closed, then shown again. Since the SigninTracker expects to always be observed, the OneClickSigninSyncStarter should only handle the first OnAccountAddedToCookie notification.
,
Apr 6 2016
Issue 600545 has been merged into this issue.
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a95a409b9f1d29e963de1528220b7c607b45996f commit a95a409b9f1d29e963de1528220b7c607b45996f Author: anthonyvd <anthonyvd@chromium.org> Date: Thu Apr 07 14:21:58 2016 Only handle the first AccountAddedToCookie event in OneClickSigninSyncStarter BUG= 601048 Review URL: https://codereview.chromium.org/1862963003 Cr-Commit-Position: refs/heads/master@{#385749} [modify] https://crrev.com/a95a409b9f1d29e963de1528220b7c607b45996f/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/a95a409b9f1d29e963de1528220b7c607b45996f/chrome/browser/ui/sync/one_click_signin_sync_starter.h
,
Apr 11 2016
,
Apr 11 2016
Issue 600948 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by anthonyvd@chromium.org
, Apr 6 2016