full screen mode for popup window loses/hides window controls
Reported by
stryjews...@gmail.com,
Apr 6 2016
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36 Steps to reproduce the problem: 1. go to https://jsbin.com/xowuzu/edit?html,output 2. click on the link 3. enter OSX native full-screen mode on the popup with the green button 4. try to exit it the same way 4. try to exit full-screen mode What is the expected behavior? the window-control buttons should be accessible when in full-screen mode on popup What went wrong? controls were hidden and the user has no clear way to exit the full-screen mode (except for navigating to [view > exit full screen] or using keyboard shortcut) Did this work before? N/A Chrome version: 49.0.2623.87 Channel: n/a OS Version: OS X 10.11.4 Flash Version: Shockwave Flash 21.0 r0
,
Apr 6 2016
,
Apr 6 2016
A bisect isn't necessary, since this isn't a recent regression. I have a good idea what is happening, this is most likely happening because this is an edge case for hiding the system title bar in fullscreen. I fixed a similar issue with the app window so the change shouldn't be too bad. I don't have the bandwidth to work on this now, but I'll start this once I have the chance
,
Apr 7 2016
,
Sep 15 2016
Issue 639398 has been merged into this issue.
,
Sep 15 2016
,
Sep 15 2016
Issue 534725 has been merged into this issue.
,
Sep 15 2016
,
Oct 30 2017
Issue 779521 has been merged into this issue.
,
Oct 31 2017
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a84fdabbb93cbe6db4366eff24d2ed438f6e1e0e commit a84fdabbb93cbe6db4366eff24d2ed438f6e1e0e Author: spqchan <spqchan@chromium.org> Date: Thu Nov 09 18:40:53 2017 [Mac] Fix Fullscreen Issue for Popup Windows In OSX 10.10+, some combination of the titlebar and toolbar always show in fullscreen mode. We do not want either to show so we hide the window that contains these views. This way, only our custom toolbar will show on the screen. However, this cause an issue where the titlebar disappears for windows without our custom toolbar (Ex/ Chrome app windows and popups). This CL adds a check so that that we only hide the window if it has a toolbar. Bug: 601038 Change-Id: Ia125273a534d69b4ad406dc2d5329d31f2d97602 Reviewed-on: https://chromium-review.googlesource.com/758500 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#515221} [modify] https://crrev.com/a84fdabbb93cbe6db4366eff24d2ed438f6e1e0e/chrome/browser/ui/cocoa/browser_window_controller_private.mm
,
Nov 9 2017
,
Nov 10 2017
Tested the issue on Latest Chrome# 64.0.3264.0 using Mac OS X 10.12.6 and found the issue to be fixed. Screen cast added for further reference. Hence adding TE-Verified labels accordingly. Thank You.
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by meh...@chromium.org
, Apr 6 2016Components: -UI UI>Browser>FullScreen
Status: Untriaged (was: Unconfirmed)