Issue 601034 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	treib@chromium.org
Closed:	Apr 2016
Cc:	█ ramyan@chromium.org
Components:	UI>Browser>NewTabPage
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
zine-mr-mile-MVP zine-mr-mvp zine-mr-iter-9

Blocking:
issue 584266

[tracking bug] Don't re-fetch snippets on every NTP load

Project Member Reported by treib@chromium.org, Apr 6 2016

Issue description

Currently, FetchSnippets is called on every NTP load. Figure out why, and do something about it.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a42da0526ecd8890becdb10f334e41a0365d9d37

commit a42da0526ecd8890becdb10f334e41a0365d9d37
Author: treib <treib@chromium.org>
Date: Thu Apr 07 10:59:35 2016

[NTP Snippets] SnippetsController cleanup: remove SigninStateObserver
The logic for fetching snippets now lives on the C++ side.

BUG= 601034 

Review URL: https://codereview.chromium.org/1864163006

Cr-Commit-Position: refs/heads/master@{#385709}

[modify] https://crrev.com/a42da0526ecd8890becdb10f334e41a0365d9d37/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
[modify] https://crrev.com/a42da0526ecd8890becdb10f334e41a0365d9d37/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java
[modify] https://crrev.com/a42da0526ecd8890becdb10f334e41a0365d9d37/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b08521135f70763c671ea87c6d792c82b690b79

commit 9b08521135f70763c671ea87c6d792c82b690b79
Author: treib <treib@chromium.org>
Date: Fri Apr 08 09:08:43 2016

[NTP Snippets] Re-fetch snippets on ML changes only when the hosts actually change

Every time the NTP is opened, the suggestions are refreshed, resulting in an OnSuggestionsChanged call.
Instead of blindly re-fetching snippets each time, store the list of hosts we saw previously, and only re-fetch when those change.

BUG= 601034 

Review URL: https://codereview.chromium.org/1863133003

Cr-Commit-Position: refs/heads/master@{#386023}

[modify] https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79/components/ntp_snippets/ntp_snippets_fetcher.cc
[modify] https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79/components/ntp_snippets/ntp_snippets_fetcher.h
[modify] https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79/components/ntp_snippets/ntp_snippets_service.h
[modify] https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79/components/ntp_snippets/pref_names.cc
[modify] https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79/components/ntp_snippets/pref_names.h