New issue
Advanced search Search tips

Issue 601031 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2016
Cc:
kolos@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Forms are not detected on some sites. Improve forms detection

Project Member Reported by kolos@chromium.org, Apr 6 2016 
Version: 51.0.2702.0 (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Go to www.tumblr.com
(2) Go to signup form

What is the expected output?
frame->document().forms(forms) should return at least one form. 

What do you see instead?
frame->document().forms(forms) returns empty list.

Comment 1 by dvadym@chromium.org, Apr 27 2016 

SignUp form on tumbler.com is skipped because during the parsing of HTML form after finishing of loading in password_form_conversion_utils.cc in function GetPasswordForm all fields are disabled and in a line
 if (!input_element || !input_element->isEnabled())
      continue;
all of them are skipped.

The question is it ok to drop a verification isEnabled()? Whether will it have some side effects?

Comment 2 by vabr@chromium.org, Apr 28 2016 

GetPasswordForm is used to get forms for filling, for password generation and for saving. If we ensure that we handle cases like saving a form with an empty password (which I believe we do), filling a disabled field (no idea) or generating a password in a disabled field (no idea), then I think dropping the mentioned isEnabled() check could work.

Comment 3 by vabr@chromium.org, May 31 2016

Labels: Hotlist-Polish
Status: Available (was: Untriaged)

Comment 4 by kolos@chromium.org, Dec 14 2016

Status: Fixed (was: Available)
At this time, www.tumblr.com utilizes yahoo.com authorization. Chrome saves passwords on signin and signup pages (when it is redirected yahoo.com). 

But Chrome doesn't autofill username before the user has been redirected to yahoo.com, i.e. tumblr.com. It is just one non-password field. We can't do anything here.
►

Sign in to add a comment