New issue
Advanced search Search tips

Issue 601013 link

Starred by 1 user
Status: Fixed
Owner:
kolos@chromium.org
Closed: Apr 2016
Cc:
kolos@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Password generation on www.tumblr.com causes crashing

Project Member Reported by kolos@chromium.org, Apr 6 2016 

What steps will reproduce the problem?
(1) Go to www.tumblr.com
(2) Manually generate password on signup form
(3) Go through the registration

What is the expected output?
Successful registration.

What do you see instead?
Crash.
[18937:18937:0404/151812:FATAL:password_form_manager.cc(279)] Check failed: state_ == MATCHING_PHASE || state_ == POST_MATCHING_PHASE. 0

Comment 1 by kolos@chromium.org, Apr 7 2016 

Chrome doesn't find any form during page loading. When user request to generate password, new PasswordFormManager should be created. At this point, new form manager doesn't fetch data from the password store. So, the check of matching phase fails.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35ecc03672a8405f2fea544dbe846518d1a6e4cf

commit 35ecc03672a8405f2fea544dbe846518d1a6e4cf
Author: kolos <kolos@chromium.org>
Date: Thu Apr 07 15:21:03 2016

[Password Manager] Call FetchDataFromPasswordStore for new password form manager, if there was no corresponding form manager.

Also removes "manager->set_has_generated_password(true)" in PasswordManager::SetGenerationElementAndReasonForForm, because it is just setting generation element, the password hasn't been generated yet.

BUG= 601013 

Review URL: https://codereview.chromium.org/1863073002

Cr-Commit-Position: refs/heads/master@{#385762}

[modify] https://crrev.com/35ecc03672a8405f2fea544dbe846518d1a6e4cf/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/35ecc03672a8405f2fea544dbe846518d1a6e4cf/components/password_manager/core/browser/password_manager_unittest.cc

Comment 3 by kolos@chromium.org, Apr 7 2016

Status: Fixed (was: Started)
►

Sign in to add a comment