New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 601011 link

Starred by 1 user
Status: Fixed
Owner:
█ davve@opera.com
inactive
Closed: Apr 2016
Cc:
nyerramilli@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Unwanted white line is seen under 'Locate' and 'phone' icon at "mullenlowelintas.in"

Reported by adha...@etouch.net, Apr 6 2016 
Chrome Version:51.0.2701.0 (Official Build)5d32c4d7ac9cd3e4a45a5cc1fc547103b66816c7-refs/heads/master@{#385337}(32/64-bit)
OS:ALL(Aero enabled)

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://www.mullenlowelintas.in/
(2)Scroll down the page.
(3)Observe the 'Locate' and 'phone' icon in 'Find us' section (L.H.S of the page).

Actual:Unwanted white line is seen under 'Locate' and 'phone' icon
Expected:No Unwanted white line should be seen.

This is a Regression issue broken in M-51,below is the Narrow bisect information:
https://chromium.googlesource.com/chromium/src/+log/84f2cfba1b8749ed115a0cca316c2dca0c12d674..fd1c745dd969cb4147c744cc0bbc16b0c5bdf26e?pretty=fuller&n=1000

Suspecting:r379801?

Good build:51.0.2671.0
Bad build:51.0.2672.0

please help to reassign if your change is not the cause for this issue.
actual.png
277 KB View Download
expected.png
286 KB View Download

Comment 1 by schenney@chromium.org, Apr 19 2016

Labels: -Pri-1 Pri-2
This is a very tiny rendering artifact, even if a regression. Reducing priority.

Comment 2 by davve@opera.com, Apr 22 2016

Status: Started (was: Assigned)

Comment 3 by davve@opera.com, Apr 22 2016

Components: Blink>SVG
I assume this has to do with the fractions in the viewBox attribute and how we handle them (or the resulting aspect ratio): ... viewBox="0 0 81.914 81.859".

Comment 4 by davve@opera.com, Apr 22 2016 

By merging image sizing algorithms this particular case has moved from being computed in LayoutUnits to floats.

Comment 5 by davve@opera.com, Apr 22 2016 

This was kind of broken before too, but LayoutUnit having worse precision than floats (in the relevant span) hid the bug for this particular viewBox. Alter the viewBox or size of the element having the background and the bug is there in M49 too.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c53a0d93dd13a025e65668dda879f78142459e04

commit c53a0d93dd13a025e65668dda879f78142459e04
Author: davve <davve@opera.com>
Date: Fri Apr 22 17:56:04 2016

Align image sizes for SVG with raster image size

The background geometry calculations has heuristics for tiling image
sizes optimized for integer image sizes (at least in effective zoom ==
1). Rounding SVG image sizes before zoom application makes SVG images
fit better into the existing heuristics.

BUG= 601011 

Review URL: https://codereview.chromium.org/1912063004

Cr-Commit-Position: refs/heads/master@{#389158}

[modify] https://crrev.com/c53a0d93dd13a025e65668dda879f78142459e04/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/c53a0d93dd13a025e65668dda879f78142459e04/third_party/WebKit/LayoutTests/svg/css/background-non-integer-viewbox-expected.html
[add] https://crrev.com/c53a0d93dd13a025e65668dda879f78142459e04/third_party/WebKit/LayoutTests/svg/css/background-non-integer-viewbox.html
[modify] https://crrev.com/c53a0d93dd13a025e65668dda879f78142459e04/third_party/WebKit/Source/core/style/StyleImage.cpp

Comment 7 by davve@opera.com, Apr 25 2016

Labels: Merge-Request-51

Comment 8 by tin...@google.com, Apr 25 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfb0382772681567f2ef5f55948912a223997c8e

commit dfb0382772681567f2ef5f55948912a223997c8e
Author: David Vest <davve@opera.com>
Date: Mon Apr 25 08:20:07 2016

Align image sizes for SVG with raster image size

The background geometry calculations has heuristics for tiling image
sizes optimized for integer image sizes (at least in effective zoom ==
1). Rounding SVG image sizes before zoom application makes SVG images
fit better into the existing heuristics.

BUG= 601011 

Review URL: https://codereview.chromium.org/1912063004

Cr-Commit-Position: refs/heads/master@{#389158}
(cherry picked from commit c53a0d93dd13a025e65668dda879f78142459e04)

Review URL: https://codereview.chromium.org/1918743002 .

Cr-Commit-Position: refs/branch-heads/2704@{#208}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/dfb0382772681567f2ef5f55948912a223997c8e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/dfb0382772681567f2ef5f55948912a223997c8e/third_party/WebKit/LayoutTests/svg/css/background-non-integer-viewbox-expected.html
[add] https://crrev.com/dfb0382772681567f2ef5f55948912a223997c8e/third_party/WebKit/LayoutTests/svg/css/background-non-integer-viewbox.html
[modify] https://crrev.com/dfb0382772681567f2ef5f55948912a223997c8e/third_party/WebKit/Source/core/style/StyleImage.cpp

Comment 10 by davve@opera.com, Apr 25 2016

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d6053b6f1157257d1951717700b007b10c021b

commit d0d6053b6f1157257d1951717700b007b10c021b
Author: davve <davve@opera.com>
Date: Mon Apr 25 10:12:36 2016

Manually rebaseline two tests from r389158

TBR=fs
BUG= 601011 

Review URL: https://codereview.chromium.org/1916733002

Cr-Commit-Position: refs/heads/master@{#389437}

[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/e5b8b2832fccc2cbe039698235669b029778f58d/third_party/WebKit/LayoutTests/platform/android/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/mac/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/win/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d6053b6f1157257d1951717700b007b10c021b

commit d0d6053b6f1157257d1951717700b007b10c021b
Author: davve <davve@opera.com>
Date: Mon Apr 25 10:12:36 2016

Manually rebaseline two tests from r389158

TBR=fs
BUG= 601011 

Review URL: https://codereview.chromium.org/1916733002

Cr-Commit-Position: refs/heads/master@{#389437}

[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/e5b8b2832fccc2cbe039698235669b029778f58d/third_party/WebKit/LayoutTests/platform/android/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/mac/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/win/css2.1/20110323/background-intrinsic-004-expected.png
[modify] https://crrev.com/d0d6053b6f1157257d1951717700b007b10c021b/third_party/WebKit/LayoutTests/platform/win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
►

Sign in to add a comment