Usage of SUID sandbox is wrongly determined when adjusting the OOM score
Reported by
tomas.po...@gmail.com,
Apr 6 2016
|
||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.110 Safari/537.36 Steps to reproduce the problem: 1. Build Chromium 50.0.2661.57 on a system without namespaces support (in this case RHEL 6) 2. Try to run it and observe errors printed on the console: [10746:10803:0406/101942:ERROR:zygote_host_impl_linux.cc(167)] Failed to adjust OOM score of renderer with pid 10849: Permission denied What is the expected behavior? No errors printed and the SUID sandbox is used. What went wrong? There is a mistake introduced in https://codereview.chromium.org/1702273002 as there is a missing "not" in https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/zygote_host/zygote_host_impl_linux.cc&l=53 . When the SUID binary is used the sandbox_binary_ is not empty (also as written in the comment above). Did this work before? Yes Before https://codereview.chromium.org/1702273002 Chrome version: 50.0.2661.57 Channel: beta OS Version: Flash Version: Shockwave Flash 21.0 r0
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8047e8e3db7bb1878da59f18446b15b123f1edf commit c8047e8e3db7bb1878da59f18446b15b123f1edf Author: tomas.popela <tomas.popela@gmail.com> Date: Thu Apr 07 12:31:09 2016 Correctly determine if the SUID sandbox will be used for adjusting the OOM score The SUID sandbox will be used when a path to it is not empty as per the "A non empty sandbox_cmd means we want a SUID sandbox" comment. R=rickyz@chromium.org BUG= 601004 Review URL: https://codereview.chromium.org/1867563002 Cr-Commit-Position: refs/heads/master@{#385723} [modify] https://crrev.com/c8047e8e3db7bb1878da59f18446b15b123f1edf/content/browser/zygote_host/zygote_host_impl_linux.cc
,
Apr 7 2017
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||
►
Sign in to add a comment |
||
Comment 1 by rnimmagadda@chromium.org
, Apr 7 2016