Issue metadata
Sign in to add a comment
|
[Marshmallow] OFFLINE page thunder icon is seen missing in page info bar of incognito tab
Reported by
ahalder@etouch.net,
Apr 6 2016
|
||||||||||||||||||||
Issue descriptionApplication Version: Chrome Dev 51.0.2701.0 Android Build Number: 6.0.1/MMB29V Device: Spice Mi-498 Pre-condition: 1. 'Enabled as saved pages' flag should be ENABLED under chrome://flags 2. WiFi/data network should be ON Steps to reproduce: 1. Launch Chrome > Go to m.facebook.com and m.youtube.com and save both the pages OFFLINE 2. Force stop Chrome > Turn WiFi/data network OFF > Relaunch Chrome now 3. Open the saved OFFLINE page in a non-incognito tab > Check the thunder icon in page info bar now 4. Open the saved OFFLINE page in incognito tab > Check the thunder icon in page info bar now Observed behavior: OFFLINE page thunder icon is seen missing in page info bar of incognito tab Expected behavior: OFFLINE page thunder icon should always be seen in the page info bar of incognito tab as seen on non-incognito tabs Frequency: <5/5> Additional comments: This issue is not present in any of the builds of M49 milestone M50 regression: Last Good Build: 50.0.2661.17 First Bad Build: 50.0.2661.18 M51 regression: Last Good Build: 51.0.2666.0 First Bad Build: 51.0.2677.0 This issue is seen on Android M devices ex. Spice Mi-498 (6.0/MRA58M), Micromax Canvas A1 (6.0.1/MMB29Q), Nexus 9 (6.0.1/MMB29S) as of now
,
Apr 6 2016
,
Apr 6 2016
I cannot repro, but will keep on investigating
,
Apr 7 2016
Can u try with any of the above mentioned device once?
,
Apr 7 2016
I got that to reproduce on Marshmallow.
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc5e1779e3e08c42092a4658df824e3f08f50b41 commit cc5e1779e3e08c42092a4658df824e3f08f50b41 Author: fgorski <fgorski@chromium.org> Date: Fri Apr 08 20:00:23 2016 [Offline pages] Properly mutating bolt icon on incognito tab. mutate() should be called on the incognito tab before the icon is updated to make sure it does not cause the OIB icon disappear. BUG= 601000 R=newt@chromium.org Review URL: https://codereview.chromium.org/1867373003 Cr-Commit-Position: refs/heads/master@{#386174} [modify] https://crrev.com/cc5e1779e3e08c42092a4658df824e3f08f50b41/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
,
Apr 8 2016
This is fixed in M51. Due to this bug affecting only limited number of users, given conditions to get here, we won't be merging it to M50.
,
Apr 15 2016
Verified fixed on a marshmallow device with Chrome 51.0.2704.10 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dknandiraju@chromium.org
, Apr 6 2016