New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600976 link

Starred by 1 user
Status: Fixed
Owner:
█ nona@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
tkent@chromium.org
kojii@chromium.org
e...@chromium.org
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean Up: Move some files in platform/fonts to platform/text

Project Member Reported by nona@chromium.org, Apr 6 2016 
Version: ToT
OS: Any

This is for tracking cleaning ups in platform/fonts
From my recent code review, it turned out that platform/text is more appropriate for some files in platform/fonts

From the comment on [1], platform/fonts/Characters.h and related files should go platform/text
From the comment on [2], entire platform/fonts/shaping should go platform/text

[1] https://codereview.chromium.org/1844663002/
[2] https://codereview.chromium.org/1847853004/

Comment 1 by drott@chromium.org, Apr 6 2016 

I would tend to disagree that shaping/ should go to text since it's mostly font dependent. However, the SymbolsIterator, RunSegmenter, etc. would be better in text/. 

However, on a larger scope, this code is not platform-dependent any more, so maybe there would even be a better place for it that platform/text.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47ae6230898a93adc77339a6995aef25022a3072

commit 47ae6230898a93adc77339a6995aef25022a3072
Author: nona <nona@chromium.org>
Date: Thu Apr 07 09:25:44 2016

Move Character.h from platform/fonts to platform/text

TBR=eae
BUG= 600976 

Review URL: https://codereview.chromium.org/1847853004

Cr-Commit-Position: refs/heads/master@{#385698}

[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/editing/state_machines/BackspaceStateMachine.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/editing/state_machines/BackwardGraphemeBoundaryStateMachine.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/editing/state_machines/ForwardGraphemeBoundaryStateMachine.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/editing/state_machines/StateMachineUtil.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/FontOrientation.h
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.h
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/platform_generated.gyp
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/Character.cpp
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/Character.h
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/CharacterProperty.h
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/CharacterPropertyData.cpp
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.h
[rename] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/CharacterTest.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/TextBreakIterator.cpp
[modify] https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072/third_party/WebKit/Source/platform/text/TextRun.cpp

Comment 3 by e...@chromium.org, Aug 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment