New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600963 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Integer-overflow in media::H264Parser::ReadUE

Project Member Reported by ClusterFuzz, Apr 6 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6273510111969280

Fuzzer: libfuzzer_media_h264_parser_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  media::H264Parser::ReadUE
  media::H264Parser::ParseSPS
  LLVMFuzzerTestOneInput
  

Minimized Testcase (0.03 Kb): https://cluster-fuzz.appspot.com/download/AMIfv940DX7TuO8q_Wi13yh3JoXhnILhtUhVzRGhxtxjoTZ1ttGGN2wMRh2uiSWlA7riMPRB5pGloniPaxOOPwE6PsXYiUwWv-sct5jmG4VgjrY_855S2agugoqw-XQdb2bP1sZ58SUXXPa99_4_SjAd6mEOm9JdBQ

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: kcc@chromium.org aizatsky@chromium.org dalecur...@chromium.org infe...@chromium.org
Labels: Stability-UndefinedBehaviorSanitizer
Owner: jrumm...@chromium.org
Ooh our first real catch? :)
Status: Started (was: Available)
Code is "*val = (1 << num_bits) - 1;" where num_bits = 31.
Cc: mmoroz@chromium.org
Labels: -Stability-Crash
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9373fc3e3743eaf0a3a835033bc89ad7b22df9d7

commit 9373fc3e3743eaf0a3a835033bc89ad7b22df9d7
Author: jrummell <jrummell@chromium.org>
Date: Thu Apr 07 23:20:08 2016

Avoid integer overflow errors when parsing Exp-Golomb codes

Maximum value is 2^31 - 1.

BUG= 600963 
TEST=media_unittests pass

Review URL: https://codereview.chromium.org/1865203002

Cr-Commit-Position: refs/heads/master@{#385918}

[modify] https://crrev.com/9373fc3e3743eaf0a3a835033bc89ad7b22df9d7/media/filters/h264_bit_reader.cc
[modify] https://crrev.com/9373fc3e3743eaf0a3a835033bc89ad7b22df9d7/media/filters/h264_parser.cc

Status: Fixed (was: Started)
Project Member

Comment 7 by ClusterFuzz, Apr 8 2016

ClusterFuzz has detected this issue as fixed in range 385844:385940.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6273510111969280

Fuzzer: libfuzzer_media_h264_parser_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  media::H264Parser::ReadUE
  media::H264Parser::ParseSPS
  LLVMFuzzerTestOneInput
  
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=385844:385940

Minimized Testcase (0.03 Kb): https://cluster-fuzz.appspot.com/download/AMIfv940DX7TuO8q_Wi13yh3JoXhnILhtUhVzRGhxtxjoTZ1ttGGN2wMRh2uiSWlA7riMPRB5pGloniPaxOOPwE6PsXYiUwWv-sct5jmG4VgjrY_855S2agugoqw-XQdb2bP1sZ58SUXXPa99_4_SjAd6mEOm9JdBQ

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: Stability-Crash

Comment 9 by w...@chromium.org, Apr 15 2016

 Issue 540970  has been merged into this issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment