Regression:Image of handbag doesn't appear after clicking on it.
Reported by
vku...@etouch.net,
Apr 6 2016
|
||||||||||
Issue descriptionChrome Version: 51.0.2701.0 (Official Build) 5d32c4d7ac9cd3e4a45a5cc1fc547103b66816c7-refs/heads/master@{#385337} (32/64 Bit) OS:Win 7(Aero enabled),Win 8 What steps will reproduce the problem? 1.Launch chrome and navigate to TheBay.com 2.Click on 'handbags' from menu(header section) and click on any back,observe Actual: Image of handbag doesn't appear after clicking on it. Expected: Image of handbag should appear after clicking on it. This is a regression issue broken in 'M51' and will soon update other info.
,
Apr 6 2016
None of the changes in that range look particularly suspicious, but my change didn't even change code, so that's certainly not it. How confident are you in the bisect?
,
Apr 7 2016
in reply to c#2, re-tried the bisect and got the same info.. Good Build: 51.0.2673.0 Bad Build: 51.0.2674.0 CL: https://chromium.googlesource.com/chromium/src/+log/740c4109f954a11c544c02132a89fabab767e7ab..9ca99ec409a1d6f7baf6dd3cd6929e81c967cac1?pretty=fuller&n=30 Note : this is working fine in FF 45.0.1 and IE 11 Could you please check the issue and let us know if you need any more information.
,
Apr 7 2016
adding RB-label as this is recent regression, please change if required.
,
Apr 11 2016
Just to update, verified the issue on Latest Canary# 51.0.2704.2 on Windows, Mac and Linux and is still able to reproduce the issue. Thank You.
,
Apr 14 2016
Just to update still seeing this issue on canary 52.0.2708.0 on Win 7 and MAC 10.11.4. Could some one please take a look into it.
,
Apr 18 2016
Still seeing this issue on windows using latest canary 52.0.2711.0. Could any one from dev team please look into this issue. Thanks,
,
Apr 18 2016
Okay, I can confirm that I see the issue and that it looks like it worked fine in M49.
,
Apr 19 2016
Okay, I re-ran the bisect myself, and, sure enough, it looks like https://codereview.chromium.org/1783693002 is what breaks this. I have no idea why. @yuzus, can you take a look?
,
Apr 19 2016
I can also confirm that we can still revert that change at tip-of-tree if we wanted to (i.e., there are no merge conflicts).
,
Apr 21 2016
@yuzus: Request you to please take a look into it. Issue is marked with a blocker label. Also issue still persists on current canary 52.0.2713.0 on Win 7, MAC 10.11.4, Ubuntu 14.04.
,
Apr 25 2016
@yuzus : Gentle Ping.Issue still observed on canary 52.0.2715.0.
,
Apr 27 2016
cc'ing reviewers from the suspected CL from Comment#9, To get this bug fixed as I am still seeing the issue on latest Chrome Beta i.e., 51.0.2704.29 on Windows, Mac and Linux.
,
Apr 27 2016
hayato@ Looks like adding .rootNode to Element seems to have broken some pages? We might need to pick a different name.
,
Apr 27 2016
,
Apr 28 2016
The Element.rootNode spec is already upstreamed to the DOM spec: https://dom.spec.whatwg.org/#dom-node-rootnode This is the result of agreement among vendors, so it is hard to rename or revert the change. Adding a new interface to Element inevitably cause breaks on some forward-incompatible sites. https://github.com/w3c/webcomponents/issues/80 (Note that this could also happen who uses their own Node.isConnected) Probably it's too late to rename the API and all we can do is to notice the site owner/author to pick a different name.
,
Apr 28 2016
Here's intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/LpXX7Svx8IY/Hu54zinaAwAJ > Interoperability and Compatibility Risk > This is a brand new feature so there is no risk of compatibility. > As for interoperability, Webkit already implemented it. > http://trac.webkit.org/changeset/195682 Probably we should be careful to add a new interface to existing namespace in the future.
,
Apr 28 2016
BTW, the code that uses 'rootNode' seems this one: http://www.thebay.com/wcsstore/TheBay/dist/js/product-display.js The usage seems to me that 'rootNode' is used for a key of JS object, so basically it should not conflict with Node.rootNode. Maybe some code like checking if e.rootNode is undefined or not to determine that |e| is the user-defined object or not, but when a Node is passed as |e| on newer Chrome, e.rootNode is not undefined and the code exposes unexpected behavior.
,
Apr 28 2016
Would adding [Unscopable] fix this?
,
Apr 30 2016
FYI. The discussion in on-going on whatwg/dom: https://github.com/whatwg/dom/issues/241
,
May 4 2016
See also bug 608006 . |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by vku...@etouch.net
, Apr 6 2016Owner: dpranke@chromium.org
Status: Assigned (was: Unconfirmed)
81.8 KB
81.8 KB View Download
181 KB
181 KB View Download
837 KB
837 KB Download