MacViews: failing views_unittests (M51 edition) |
||||
Issue descriptionVersion: 51.0.2689.0 OS: Mac 10.11.3 BubbleDialogDelegateTest.CloseMethods fails on MacViews. The test was added recently - https://codereview.chromium.org/1809933003
,
Apr 14 2016
The problem is that the bubble is being shown without its parent (the anchor widget) having ever being shown in the first place, which passes on Aura because of crbug.com/590957 , which was picked up earlier by a similar test failing on MacViews. Will send out a CL for a simple fix which is just to show the anchor widget before the bubble.
,
Apr 20 2016
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfe263607137b4c4af5cb42fcf9a2d6cb7cc4183 commit bfe263607137b4c4af5cb42fcf9a2d6cb7cc4183 Author: patricialor <patricialor@chromium.org> Date: Thu Apr 21 08:22:42 2016 MacViews: Fix BubbleDialogDelegateTest.CloseMethods BubbleDialogDelegateTest.CloseMethods, added in http://crrev.com/1809933003 (r382045) fails on MacViews because bubbles cannot be shown unless their parents are already visible. This is expected behaviour, so fix it by showing the parent anchor widget immediately after creation (which affects all tests calling CreateTestWidget()). Note this test passes on Aura because of http://crbug.com/590957 . BUG= 590957 , 600921 Review URL: https://codereview.chromium.org/1891823004 Cr-Commit-Position: refs/heads/master@{#388720} [modify] https://crrev.com/bfe263607137b4c4af5cb42fcf9a2d6cb7cc4183/ui/views/bubble/bubble_dialog_delegate_unittest.cc
,
May 2 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ellyjo...@chromium.org
, Apr 12 2016Owner: patricia...@chromium.org
Status: Assigned (was: Untriaged)