Issue metadata
Sign in to add a comment
|
Misplaced system tray on ToT |
||||||||||||||||||||||
Issue descriptionSee screenshot. This happens on my current ToT: commit 3accf1e624bb65f3c4b594e646b54b28dab05c21 Author: dcheng <dcheng@chromium.org> Date: Tue Apr 5 20:25:55 2016 -0700
,
Apr 6 2016
,
Apr 6 2016
reproduced on lulu too.
,
Apr 6 2016
Issue 601099 has been merged into this issue.
,
Apr 6 2016
+msw, could this be related to https://codereview.chromium.org/1851883002 "Cleanup shelf initialization and observation."? Maybe it's missing a layout during setup? It could also be related to my elimination of SHELF_ALIGNMENT_TOP, though I doubt it. https://codereview.chromium.org/1849623002
,
Apr 6 2016
Yeah, this is likely a regression from my CL, I'll take a look asap.
,
Apr 6 2016
I tried reverting my SHELF_ALIGNMENT_TOP CL and that wasn't it. At least, I still see the tray widget in the top-left with: out/Default/chrome --user-data-dir=/tmp/udd --login-manager
,
Apr 6 2016
I have a local fix at https://codereview.chromium.org/1866113002
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9da4d84543481779c974d26b8c3536fdd0249e5 commit f9da4d84543481779c974d26b8c3536fdd0249e5 Author: msw <msw@chromium.org> Date: Thu Apr 07 18:19:35 2016 Fix Chrome OS Login status area layout. Let ShelfLayoutManager perform layout before a shelf exists. Fixes a regression from https://codereview.chromium.org/1851883002 Generalize NoSessionRootWindowControllerTest.Event (ensure event handler(s) exists, not necessarily a single handler) (not sure why it's only now finding the status area as a handler...) Tested locally with: chrome --login-manager --login-profile=user --user-data-dir=/tmp/foo BUG= 600911 TEST=Status area is placed on bottom right during cros login R=sky@chromium.org Review URL: https://codereview.chromium.org/1866113002 Cr-Commit-Position: refs/heads/master@{#385812} [modify] https://crrev.com/f9da4d84543481779c974d26b8c3536fdd0249e5/ash/root_window_controller_unittest.cc [modify] https://crrev.com/f9da4d84543481779c974d26b8c3536fdd0249e5/ash/shelf/shelf_layout_manager.cc
,
Apr 7 2016
Should be fixed on ToT, please let me know if anything else arises; thanks!
,
Apr 7 2016
Issue 601587 has been merged into this issue.
,
Apr 7 2016
,
Apr 8 2016
Thanks Mike!
,
Apr 11 2016
Issue 602166 has been merged into this issue.
,
Apr 11 2016
Still seen issue on Chrome:51.0.2701.0/Chromeos:8178.0.0
,
Apr 11 2016
abodeti@, https://omahaproxy.appspot.com says version 51.0.2701.0 has Branch Base Position: 385337. My fix should be at position #385812, please test if a build after that fix is any better.
,
Apr 12 2016
Verified on ChromeOS:8172.1.0 / 51.0.2704.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abodenha@chromium.org
, Apr 6 2016Labels: ReleaseBlock-Beta M-51 OS-Chrome
Owner: dzhioev@chromium.org
Status: Assigned (was: Untriaged)