run-webkit-tests: Fix all the causes of errors in the httpd "error_log.txt" file. |
||||||
Issue descriptionCurrently even with a successful run_webkit_tests run there are thousands of lines of errors in the error_log.txt file; examples; ---------------------------------------- [Wed Apr 06 12:56:57.442519 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: credentials in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-style.php on line 10, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-style-no-cors-no-xorigin-empty-integrity.html [Wed Apr 06 12:56:57.556206 2016] [:error] [pid 18874] [client 127.0.0.1:58656] PHP Notice: Undefined index: HTTP_LAST_EVENT_ID in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/eventsource/resources/reconnect.php on line 3, referer: http://127.0.0.1:8000/eventsource/eventsource-reconnect.html [Wed Apr 06 12:56:57.830193 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: cors in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-script.php on line 2, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-script-cors-no-xorigin.html [Wed Apr 06 12:56:57.830226 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: credentials in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-script.php on line 10, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-script-cors-no-xorigin.html [Wed Apr 06 12:56:57.830235 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: custom in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-script.php on line 13, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-script-cors-no-xorigin.html [Wed Apr 06 12:56:57.830243 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: HTTP_SUBORIGIN in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-script.php on line 18, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-script-cors-no-xorigin.html [Wed Apr 06 12:56:57.830251 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: delay in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-script.php on line 23, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-script-cors-no-xorigin.html [Wed Apr 06 12:56:57.830259 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: HTTP_ORIGIN in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-script.php on line 27, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-script-cors-no-xorigin.html [Wed Apr 06 12:56:58.001966 2016] [:error] [pid 18885] [client ::1:36078] PHP Notice: Undefined index: credentials in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/security/resources/cors-style.php on line 10, referer: http://127.0.0.1:8000/security/subresourceIntegrity/subresource-integrity-style-no-cors-no-xorigin.html [Wed Apr 06 12:56:58.079473 2016] [:error] [pid 18889] [client 127.0.0.1:58720] PHP Notice: Undefined index: HTTP_IF_NONE_MATCH in /fast/chrome/src/third_party/WebKit/LayoutTests/http/tests/resources/dpr.php on line 14, referer: http://127.0.0.1:8000/images/image-with-dpr-header.html ---------------------------------------- We should resolve the errors and then check that this file is empty.
,
Jun 7 2016
ojan / dpranke / qyearsley: Any thoughts on how we could tackle this issue? When working on test failures on swarming this file had a whole bunch of extra error messages that had I seen earlier would have saved me a couple of days of dev time. I didn't see them because they were hidden inside these thousands of other errors. It also seems generally bad that we have tests that are depending on php scripts which are so badly written that they produce this many errors. BTW Do any of you know the history about these php files?
,
Jun 7 2016
I think they've largely either been around forever or added as needed. I suppose you could make whether there were any entries in error_log.txt a step failure, but I'm pretty sure that this bug is the first that's ever been filed against this file, so I'm not sure how high a priority fixing things is, especially if we're potentially hoping to move to wptserve and python scripts instead.
,
Jun 7 2016
Bug 347864 suggests that we would want to generally remove usage of PHP files. In order to do this, I think we'd need to: 1. Make a mechanism to specify that we want to use wptserve for a particular test anywhere in LayoutTests (not just in wpt). I believe that there's a convention in the WPT tests for test files ending in .http.html or .https.html if a http server is required for the test. 2. Change individual tests that use PHP files to do an equivalent thing but using wptserve (possibly relevant examples in https://github.com/w3c/web-platform-tests/tree/master/cors).
,
Dec 27 2016
,
Mar 7 2017
,
Apr 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 13 2018
This should still be "Available". |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sshru...@google.com
, Apr 18 2016