New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600907 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Download Protection: Additional Compressed Formats for Mac OS

Reported by resea...@nightwatchcybersecurity.com, Apr 6 2016

Issue description

VERSION
Chrome Version: 49.0.2623.87 Official Build
Operating System: Mac OS X El Capitan, version 10.11.3

REPRODUCTION CASE
The following file extensions are opened by the Archive Mounter utility on Mac OS, even if they are a different extension (GZ versus ZIP). To reproduce, take any .ZIP file, and rename as one of the following extensions. Double click and the file will still be opened as ZIP. Chrome does not check these.

.AS
.CPGZ
.PAX
.XIP

We can try to provide a patch if it would qualify under Patch Rewards.
 
Labels: -Restrict-View-SecurityTeam Restrict-View-Google
Owner: ----
Attaching patch
comp.patch
5.8 KB Download
Better POC here:
https://theowl.xyz/cr/600907/test.as
https://theowl.xyz/cr/600907/test.cpgz
https://theowl.xyz/cr/600907/test.pax
https://theowl.xyz/cr/600907/test.xip

For the XIP case only, we observed Gatekeeper showing a warning, not for the rest.

Use case would be malware packaged inside one of these files, user downloads, double clicks, and double clicks.

Comment 5 by vakh@chromium.org, May 6 2016

Labels: SafeBrowsing-Triaged
Owner: vakh@chromium.org
Just wondering if this issue is still being looked at
@vakh - we are attaching a patch for the new dynamic file type system
mac_additional_archives.patch
2.3 KB Download

Comment 8 by vakh@chromium.org, Jun 3 2016

Thanks for the report and the patch. I'm looking into it and should have an update in the next 1-2 days.
Thank you

Comment 10 by vakh@chromium.org, Jun 8 2016

Labels: Hotlist-Fixit-Triaged

Comment 11 by vakh@chromium.org, Jun 9 2016

Cc: vakh@chromium.org
Owner: nparker@chromium.org
Status: Assigned (was: New)
I can confirm the following behavior:
.AS  : REASON_NOT_BINARY_FILE, (Could have been .gz)
.CPGZ: REASON_NOT_BINARY_FILE, (Could have been .gz)
.PAX : REASON_NOT_BINARY_FILE, (Could have been .zip) 
.XIP : REASON_NOT_BINARY_FILE, (Could have been .zip)

It looks like .PAX is working as intended and is being checked.

nparker: can you please take a look and fix?

Comment 12 by vakh@chromium.org, Jun 9 2016

> It looks like .PAX is working as intended and is being checked.
Please ignore this statement from my previous comment.
vakh -- Did we confirm these types are automatically opened/unpacked?

Comment 14 by vakh@chromium.org, Jun 9 2016

> vakh -- Did we confirm these types are automatically opened/unpacked?
Yes, I did that.
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e11fd0f247034347d72abd6b8c29cfec6074b16

commit 8e11fd0f247034347d72abd6b8c29cfec6074b16
Author: nparker <nparker@chromium.org>
Date: Fri Jun 10 16:47:12 2016

Add additional compressed formats for Mac OS

R=vakh
BUG= 600907 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2051213003
Cr-Commit-Position: refs/heads/master@{#399208}

[modify] https://crrev.com/8e11fd0f247034347d72abd6b8c29cfec6074b16/chrome/browser/resources/safe_browsing/download_file_types.asciipb
[modify] https://crrev.com/8e11fd0f247034347d72abd6b8c29cfec6074b16/tools/metrics/histograms/histograms.xml

Labels: Pri-2
Status: Fixed (was: Assigned)

Comment 17 by vakh@chromium.org, Jun 10 2016

Labels: reward-to-sb-panel
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e11fd0f247034347d72abd6b8c29cfec6074b16

commit 8e11fd0f247034347d72abd6b8c29cfec6074b16
Author: nparker <nparker@chromium.org>
Date: Fri Jun 10 16:47:12 2016

Add additional compressed formats for Mac OS

R=vakh
BUG= 600907 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2051213003
Cr-Commit-Position: refs/heads/master@{#399208}

[modify] https://crrev.com/8e11fd0f247034347d72abd6b8c29cfec6074b16/chrome/browser/resources/safe_browsing/download_file_types.asciipb
[modify] https://crrev.com/8e11fd0f247034347d72abd6b8c29cfec6074b16/tools/metrics/histograms/histograms.xml

Comment 19 by vakh@chromium.org, Jun 15 2016

Labels: -reward-to-sb-panel reward-2000 reward-unpaid
I'm happy to announce that the panel decide to award $2000 for this report.

research@nightwatchcybersecurity.com: Thank you for the report! I've set the wheels in motion for you to get the reward.
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5a6877b2df8b2cc36e959285e095df410e734cf

commit e5a6877b2df8b2cc36e959285e095df410e734cf
Author: nparker <nparker@chromium.org>
Date: Wed Jun 15 17:58:28 2016

Increment download_file_types version since I missed it before

I missed this in https://codereview.chromium.org/2051213003 and hence
it wont get pushed till I land+push this.

R=jialiul
BUG= 600907 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2067263002
Cr-Commit-Position: refs/heads/master@{#399950}

[modify] https://crrev.com/e5a6877b2df8b2cc36e959285e095df410e734cf/chrome/browser/resources/safe_browsing/download_file_types.asciipb

thank you
We haven't heard from anyone regarding the reward
Thanks for letting us know - I'll chase this up. Feel free to email me directly at timwillis@ if you haven't seen emails relating to this payment by mid-next week.

Comment 24 by vakh@chromium.org, Jun 23 2016

Labels: M-52

Comment 25 by vakh@chromium.org, Jun 23 2016

Labels: Security_Impact-Stable
Labels: -reward-unpaid reward-inprocess
Labels: -Restrict-View-Google
Cc: ya...@nightwatchcybersecurity.com

Comment 29 by vakh@chromium.org, Mar 10 2017

Labels: Restrict-View-SecurityTeam
For all Download Protection VRP bugs: removing label Restrict-View-Google and adding Restrict-View-SecurityTeam instead.
Project Member

Comment 30 by sheriffbot@chromium.org, Mar 11 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment