New issue
Advanced search Search tips

Issue 600887 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Elements inside <settings-subpage> don't always respond to window resize.

Project Member Reported by dpa...@chromium.org, Apr 6 2016

Issue description

Repro steps
 1) Navigate to chrome://md-settings/certificates directly from the omnibox.
 2) Try to delete a personal certificate, which should open the delete confirmation dialog.
 3) Resize the window height.

Expected result: Dialog moves as height changes, such that it is always centered.
Actual result: Dialog does not move.

It gets more interesting.

4) After step 3 above, click the left arrow next to "Manage Certificates"
5) Enter the certificate manager again by clicking "Manage Certificates" in the privacy section.
6) Repeat steps 1-3. This time the dialog responds to window resize!

Initial investigation is showing that the _interestedResizables array at [1] has different contents for the case where it works VS the case where it does not work.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/iron-resizable-behavior-extracted.js&l=82
 
Cc: michae...@chromium.org
Summary: Dialogs inside <settings-subpage> don't always respond to window resize. (was: Certificate manager dialogs don't always respond to window resize.)
The problem is more generic, updating issue description.

@michaelpg: I believe this is related to how subpages or animated pages are initialized in the case of direct navigation (using the omnibox), VS normal navigation (chrome://md-settings or chrome://md-settings/advanced). I uploaded https://codereview.chromium.org/1865753002 which illustrates the differences I have spotted so far. Let me know if you have any ideas.
FYI, I found a patch that fixes the issue, see https://codereview.chromium.org/1865753002/diff/40001/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages-extracted.js. Will follow up tomorrow, to figure out if this is the correct fix and send a PR if so.
An easier repro case is "Add search engine" from chrome://md-settings/searchEngines

(not sure how to populate the cert manager)
It turns out that the issue is fixed in latest version of neon-animated-pages. I'll leave this bug open, until the latest version has been rolled.

Comment 6 by dbeam@chromium.org, Apr 7 2016

Cc: tbuck...@chromium.org dbeam@chromium.org
 Issue 598898  has been merged into this issue.
Summary: Elements inside <settings-subpage> don't always respond to window resize. (was: Dialogs inside <settings-subpage> don't always respond to window resize.)
Renamed the bug title to better reflect the issue.
Just an FYI, I've verified these have been issues for a while and aren't specific to settings-subpage (ie, were happening before the lazy-create change). The title is still accurate though.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0e06acbb33eb8e191ab5c33ea6875859f579247

commit a0e06acbb33eb8e191ab5c33ea6875859f579247
Author: dbeam <dbeam@chromium.org>
Date: Thu Apr 07 21:27:24 2016

MD Downloads: ensure the DOM is ready before trying to find-in-page on it

This unblocks a Polymer roll: https://codereview.chromium.org/1862213002/

Which, in turn, fixes a functional issue on chrome://md-settings

R=sky@chromium.org
BUG= 600887 

Review URL: https://codereview.chromium.org/1855393007

Cr-Commit-Position: refs/heads/master@{#385870}

[modify] https://crrev.com/a0e06acbb33eb8e191ab5c33ea6875859f579247/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Status: Assigned (was: Untriaged)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/617644937cf254786783bc59b975613ea7e274fa

commit 617644937cf254786783bc59b975613ea7e274fa
Author: dschuyler <dschuyler@chromium.org>
Date: Sat Apr 23 00:42:31 2016

[Polymer] update third_party polymer

This CL updates the third party Polymer JavaScript library,
with the addition of a patch for neon-animated pages.

The patch change is shown in the chromium.patch file within
this CL.  It comes from
https://github.com/PolymerElements/neon-animation/pull/149

BUG= 600887 
TBR=dzhioev@chromium.org
NOPRESUBMIT=true
^ because crisper files are machine generated and do not obey
the 80 character limit.

Review URL: https://codereview.chromium.org/1901343004

Cr-Commit-Position: refs/heads/master@{#389329}

[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/README.chromium
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-list/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-location/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-location/iron-location-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-backdrop.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable-behavior.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animations.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-shared-element-animation-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-item/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/polymer-externs/polymer.externs.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/.bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/History.md
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/README.md
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next-lite.min.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next-lite.min.js.map
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next.min.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next.min.js.map
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations.min.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations.min.js.map

Comment 12 by dbeam@chromium.org, Apr 25 2016

dschuyler/dpapad: fixed now?
Status: Fixed (was: Assigned)
Yes, just verified.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/617644937cf254786783bc59b975613ea7e274fa

commit 617644937cf254786783bc59b975613ea7e274fa
Author: dschuyler <dschuyler@chromium.org>
Date: Sat Apr 23 00:42:31 2016

[Polymer] update third_party polymer

This CL updates the third party Polymer JavaScript library,
with the addition of a patch for neon-animated pages.

The patch change is shown in the chromium.patch file within
this CL.  It comes from
https://github.com/PolymerElements/neon-animation/pull/149

BUG= 600887 
TBR=dzhioev@chromium.org
NOPRESUBMIT=true
^ because crisper files are machine generated and do not obey
the 80 character limit.

Review URL: https://codereview.chromium.org/1901343004

Cr-Commit-Position: refs/heads/master@{#389329}

[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/README.chromium
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-list/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-location/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-location/iron-location-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-backdrop.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable-behavior.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animations.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/neon-animation/neon-shared-element-animation-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-input/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-item/bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components-chromium/polymer-externs/polymer.externs.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/.bower.json
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/History.md
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/README.md
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next-lite.min.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next-lite.min.js.map
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next.min.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations-next.min.js.map
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations.min.js
[modify] https://crrev.com/617644937cf254786783bc59b975613ea7e274fa/third_party/web-animations-js/sources/web-animations.min.js.map

Sign in to add a comment