I reproduced this locally with 52.0.2705.0. Over to groby@ - is this the expected behavior? I know there's some heuristics about when we show the page action.

In general, icon updating is tied to Browser::UpdateToolbar. This should definitely fire on reload/navigate, so assuming that's not it...

LocationBarView::TranslateIcon enables/disables the icon based on language_state.translate_enabled(). That's why "never translate" results in hiding it, I assume. 

It's been that way since the beginning of the new UX, see https://codereview.chromium.org/25373009

+hajimehoshi, juliecattiau, who'll be able to comment on if this is intentional.

If we want to fix this, we should probably rely on page_needs_translation, which IIRC will be true even if you said "never translate"

+kenjibaheux

IIUC this is intentional not to annoy users, and if you want to revert 'never translate' state, you can do it on chrome://settings/languages.

I think chrome://settings/languages allows a user to revert "never translate this *language*".

I don't know of any UI for reverting "never translate this *site*"

(chrome://settings/languages is also quite undiscoverable)

The preferred path to recovery is the context menu's Translate option.

I guess the point is that a user who fat fingered "Never translate this site" and wants to "undo" it, might not realize they have an alternative means via the context menu.

It also differs from the info at go/rtvfy which is why I made this bug in the first place :)

(personally, I also find it weird that right-clicking *text* on the page shows a different context menu; one that doesn't have a "Translate" option)

Is there UMA on the context-menu translate option?

rachelis@ and juliecattiau@, 

The latest proposal is going to fix this issue by make the icon stay even after selecting "Never", correct? 

From Alex:

"re: icon in the omnibox showing-after-never
Pendar, it might be helpful to chat with the password folks (starting with hwi@) about how they approach the permanence of their no/never choice. IIRC, their key icon stays around for the next page load so that you can undo a mis-click if you need to. But the icon is removed after that to be respectful of intentional stop-asking-me preferences."

I think the goal would be to be consistent with the password icon. That said, there's also access to translation via the context click, so we may want to think about that redundancy.

@Pendar - I seem to recall that we planned to split out the icon separately from the current proposal. Is that correct?

This issue is addressed inside the TranslateUI2016Q2 fix.

The TranslateUI2016Q2 fix doesn't seem to address this. With the new UI enabled I selected "Never translate this site". The icon is now gone and there is no way I can see to get it back.

Also note that it is chrome://translate-internals/ that lets you revert the "never translate" for sites, not chrome://settings/languages

Yana, I believe we need a product decision here. Should the icon be displayed in the omnibox even if the user has selected "Never..."

Hey Jon -  in general I think we should show the icon - my logic is that it will allow us to be more aggressive in guessing user preferences + allow users the freedom to change their minds about Never. However, this particular UI is not current on Mac so we can close this particular bug as not relevant anymore but make sure to show the icon in the new UI that we implement across desktop.

To do here: make sure the icon is showed when we are the ones suppressing the UI (through Ranker, suppression heuristics while we still have them, etc.)
To do here: show the icon x times after a user selects "Never translate" in case they have hot-keyed. 

For posterity: to start we'll show the icon whenever Chrome suppresses the UI. We will not show it if the user has blocked translations for that language or site, and we will definitely now show it if the user has disabled translations, or if translations are disabled by policy.

Checking with UI: we'd like to show it 3 times after a user selects decline for either site or language, in case they hot-fingered.

(clarification: "definitely not" instead of "definitely now")

Thanks for the catch :)

One more thing for Nicolas: could you add a metric that tracks when we show just the icon (vs the entire UI)?

Confirmed UI approval to show the icon 3x times after a user selects decline for either site or language, in case they hot-fingered. 

Also please note the companion bug to this: crbug.com/600874 also assigned to you. If a user clicks on the icon (or also if they right click after opting for Never) we need to remove them from the "Never" group with the narrowest scope.

Last: we should create a histogram to track the "hot finger undos": the number of times a user clicks on the icon after a Never in a separate UMA histogram.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd54ce72332293877692bf57ba168bce570eee71

commit bd54ce72332293877692bf57ba168bce570eee71
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Fri Jun 29 17:44:45 2018

Prevent TranslateRanker from hiding the Translate icon

With this change, TranslateRanker only suppresses the infobar/bubble UI,
but won't hide the omnibar icon for translating. This should be more convenient
in cases where TranslateRanker draws an incorrect conclusion.

Also, add a metric to track the new logical path: deciding to suppress the
infobar/bubble UI, but still show the icon.

Bug: 600874
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I73ba3e28fea1479bbdafd8baf2c5c4da92c6bf9e
Reviewed-on: https://chromium-review.googlesource.com/1115581
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571525}
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/chrome/browser/translate/chrome_translate_client.h
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/components/translate/core/browser/mock_translate_client.h
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/components/translate/core/browser/translate_browser_metrics.h
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/components/translate/core/browser/translate_client.h
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/ios/chrome/browser/translate/chrome_ios_translate_client.h
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/ios/web_view/internal/translate/web_view_translate_client.h
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/ios/web_view/internal/translate/web_view_translate_client.mm
[modify] https://crrev.com/bd54ce72332293877692bf57ba168bce570eee71/tools/metrics/histograms/enums.xml

Is it ok to mark as Fixed?

My patch helps with the issue when TranslateRanker is suppressing Translate. But the problem from the initial bug report isn't completely fixed.

It also doesn't have the 'show the icon 3 times' logic, or the histogram suggested in comment #28.

Reassigning to Anthony

Note: suspect a bug in the way the metric was added. We're seeing a spike in "Show icon to the user" on Android, where we don't show the icon.