New issue
Advanced search Search tips

Issue 600869 link

Starred by 1 user
Status: Verified
Owner: ----
Closed: Apr 2016
Cc:
jamescook@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

SetFocus() may fail and not propagate failure to client

Project Member Reported by sky@chromium.org, Apr 5 2016 
If WindowTree::SetFocus() gets to the FocusController it is assumed to pass. Unfortunately FocusController::SetFocusedWindow() may silently ignore the request, resulting in the client and server being out of sync. If FC::SetFocusedWindow ignores the request the client needs to be notified.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b88e631421343f0fd3d695b9cee0b090eb6ac1

commit f9b88e631421343f0fd3d695b9cee0b090eb6ac1
Author: sky <sky@chromium.org>
Date: Thu Apr 07 21:24:29 2016

Makes SetFocus() notify callback correctly on failure

SetFocus() may fail in the FocusController and this wasn't being
propagated correctly to the client. This meant the client might think
a window had focus when it didn't.

BUG= 600869 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1868783003

Cr-Commit-Position: refs/heads/master@{#385866}

[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/display.cc
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/display.h
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/display_unittest.cc
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/focus_controller.cc
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/focus_controller.h
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/window_server.cc
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/window_server.h
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/window_tree.cc
[modify] https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1/components/mus/ws/window_tree.h

Comment 2 by sky@chromium.org, Apr 7 2016

Status: Fixed (was: Available)

Comment 3 by patricia@chromium.org, Apr 11 2016

Labels: VerifyIn-51

Comment 4 by patricia@chromium.org, May 23 2016

Status: Verified (was: Fixed)
Bulk verified
►

Sign in to add a comment