New issue
Advanced search Search tips

Issue 600863 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

GestureStateListener#OnScrollEnded notification is unreliable

Project Member Reported by donnd@chromium.org, Apr 5 2016

Issue description

I've been trying to use GestureStateListener#OnScrollEnded but it seems to be unreliable.  When scrolling down the page and after the toolbar disappears I see scroll started but not scroll ended events most of the time.

Added some logging here to investigate: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java&q=onScrollEnded&sq=package:chromium&l=520&ct=rc&cd=1&dr=CSs

We do get a call to Java_ContentViewCore_onScrollUpdateGestureConsumed so I'm using that for now in Contextual Search.
 

Comment 1 by cmasso@google.com, Mar 7 2018

Cc: jinsuk...@chromium.org
Components: UI>Input>Touch
Owner: donnd@chromium.org
Status: Assigned (was: Untriaged)
Do you know if it is a regression?

> We do get a call to Java_ContentViewCore_onScrollUpdateGestureConsumed so I'm using that for now in Contextual Search.
 
I guess you meant Java_GestureListenerManagerImpl_onScrollUpdateGestureCommand...

Comment 3 by donnd@google.com, Mar 7 2018

> Do you know if it is a regression?
I doubt it, reported about a year ago.

> I guess you meant Java_GestureListenerManagerImpl_onScrollUpdateGestureCommand...
Maybe refactoring was done since then that moved the method.  GestureStateListener#onScrollUpdateGestureConsumed override by Contextual Search here: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java?type=cs&q=onScrollUpdateGestureConsumed&sq=package:chromium&l=98

Sign in to add a comment