New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600857 link

Starred by 1 user
Status: Fixed
Owner:
█ mge...@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update cr_cronet.py and build documentation for switch to GN

Project Member Reported by mge...@chromium.org, Apr 5 2016 
Now that we've switched our bots to GN, we should switch our local workflows too. cr_cronet.py has been updated with a 'gn' command which closely mirrors the 'gyp' command's behavior, and the documentation has been updated to reference it, but GN is intended to be used somewhat differently.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62d2e21291d90966c984748532a0f254dab2322b

commit 62d2e21291d90966c984748532a0f254dab2322b
Author: mgersh <mgersh@chromium.org>
Date: Thu Apr 28 22:54:05 2016

Update cr_cronet.py to allow arbitrary build directories

Now that we're building with GN, we aren't restricted to out/Debug and
out/Release. Some cronet developers might want to name their directories
differently.

BUG= 600857 

Review-Url: https://codereview.chromium.org/1924693005
Cr-Commit-Position: refs/heads/master@{#390524}

[modify] https://crrev.com/62d2e21291d90966c984748532a0f254dab2322b/components/cronet/tools/cr_cronet.py

Comment 2 by mge...@chromium.org, Apr 29 2016

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af00b485a970dd36e8276547c79c02a146accd5

commit 0af00b485a970dd36e8276547c79c02a146accd5
Author: mgersh <mgersh@chromium.org>
Date: Fri Jun 10 16:26:50 2016

Fix cr_cronet.py APK install when custom build directory is used

BUG= 600857 

Review-Url: https://codereview.chromium.org/2013073002
Cr-Commit-Position: refs/heads/master@{#399203}

[modify] https://crrev.com/0af00b485a970dd36e8276547c79c02a146accd5/components/cronet/tools/cr_cronet.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af00b485a970dd36e8276547c79c02a146accd5

commit 0af00b485a970dd36e8276547c79c02a146accd5
Author: mgersh <mgersh@chromium.org>
Date: Fri Jun 10 16:26:50 2016

Fix cr_cronet.py APK install when custom build directory is used

BUG= 600857 

Review-Url: https://codereview.chromium.org/2013073002
Cr-Commit-Position: refs/heads/master@{#399203}

[modify] https://crrev.com/0af00b485a970dd36e8276547c79c02a146accd5/components/cronet/tools/cr_cronet.py
►

Sign in to add a comment