New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600824 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Probably harmless partial return value check in gdi_util.cc, StretchDIBits

Reported by test35...@gmail.com, Apr 5 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.57 Safari/537.36

Steps to reproduce the problem:
1. ::StretchDIBits can return 0 or GDI_ERROR on failure
2. StretchDIBits in gdi_util only DCHECKs against GDI_ERROR
3. Errors might be missed

What is the expected behavior?
Checking against both failure codes. Win32 APIs are hard, and this is an easy one to miss.

What went wrong?
::StretchDIBits (https://msdn.microsoft.com/en-us/library/vs/alm/dd145121.aspx) may fail, and the DCHECK won't catch it.

Did this work before? N/A 

Chrome version: 50.0.2661.57  Channel: beta
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0

StretchDIBits can also return 0 if no scan lines are copied, but is that reasonable scenario anyways?
 
Cc: tkonch...@chromium.org
Labels: Te-NeedsFurtherTriage

Comment 2 Deleted

Components: UI
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 3 2017

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment