Probably harmless partial return value check in gdi_util.cc, StretchDIBits
Reported by
test35...@gmail.com,
Apr 5 2016
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.57 Safari/537.36 Steps to reproduce the problem: 1. ::StretchDIBits can return 0 or GDI_ERROR on failure 2. StretchDIBits in gdi_util only DCHECKs against GDI_ERROR 3. Errors might be missed What is the expected behavior? Checking against both failure codes. Win32 APIs are hard, and this is an easy one to miss. What went wrong? ::StretchDIBits (https://msdn.microsoft.com/en-us/library/vs/alm/dd145121.aspx) may fail, and the DCHECK won't catch it. Did this work before? N/A Chrome version: 50.0.2661.57 Channel: beta OS Version: 10.0 Flash Version: Shockwave Flash 21.0 r0 StretchDIBits can also return 0 if no scan lines are copied, but is that reasonable scenario anyways?
,
Jul 1 2016
,
Jul 3 2017
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||
►
Sign in to add a comment |
|||
Comment 1 by tkonch...@chromium.org
, Apr 6 2016Labels: Te-NeedsFurtherTriage