New issue
Advanced search Search tips

Issue 600815 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Sign in to add a comment

High DPI support for mus

Project Member Reported by rjkroege@chromium.org, Apr 5 2016

Issue description

Finish plumbing DPI around in mus so that pixel can successfully make the determination that it should be running at 2x DPI

 

Comment 1 by sadrul@chromium.org, Apr 13 2016

Blockedon: 603316
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b115788789b08177b4f38d9a0206a6c069ec4e6

commit 5b115788789b08177b4f38d9a0206a6c069ec4e6
Author: sadrul <sadrul@chromium.org>
Date: Wed Apr 20 16:02:19 2016

mus/views: Fix creating gfx::Display in high-dpi.

It's very easy to create a gfx::Display instance with incorrect values
for bounds/work-area when device-scale factor ≠ 1. This is because
when the gfx::Display is created with a specified bounds, it attempts
to automatically convert the bounds from pixel to DIP values. However,
work-area needs to set separately, and so the caller can use different
scaling factor when setting the bounds vs. setting the work-area. To
fix this, have the gfx::Display creator explicitly do the pixel-to-DIP
conversion before setting the bounds and work-area on the gfx::Display
instances.

BUG= 600815 , 605124

Review URL: https://codereview.chromium.org/1903003002

Cr-Commit-Position: refs/heads/master@{#388507}

[modify] https://crrev.com/5b115788789b08177b4f38d9a0206a6c069ec4e6/ui/aura/test/aura_test_helper.cc
[modify] https://crrev.com/5b115788789b08177b4f38d9a0206a6c069ec4e6/ui/views/mus/BUILD.gn
[modify] https://crrev.com/5b115788789b08177b4f38d9a0206a6c069ec4e6/ui/views/mus/screen_mus.cc
[add] https://crrev.com/5b115788789b08177b4f38d9a0206a6c069ec4e6/ui/views/mus/screen_mus_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba7639d4d6a012062a0d3c05dea9c222a408b66f

commit ba7639d4d6a012062a0d3c05dea9c222a408b66f
Author: kjellander <kjellander@chromium.org>
Date: Thu Apr 21 10:40:30 2016

Revert of mus: Fix event transformation in client code. (patchset #3 id:40001 of https://codereview.chromium.org/1906603002/ )

Reason for revert:
Speculative revert for failing interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1), starting with
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/11887

Failure:
[ RUN      ] DragDropTest.DragDropAcrossMultiDisplay
Xlib:  extension "RANDR" missing on display ":9".
[9809:9809:0420/230942:21040728698:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x61600006c980
Xlib:  extension "RANDR" missing on display ":9".
../../ash/drag_drop/drag_drop_interactive_uitest.cc:153: Failure
Value of: target_view->dropped()
  Actual: false
Expected: true
[9809:9809:0420/230942:21040854605:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x61600006c980
[  FAILED  ] DragDropTest.DragDropAcrossMultiDisplay (231 ms)

Original issue's description:
> mus: Fix event transformation in client code.
>
> Make sure that events are transformed correctly (for high-dpi) in mus
> clients.
>
> BUG= 600815 

TBR=sky@chromium.org,sadrul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 600815 

Review URL: https://codereview.chromium.org/1908913002

Cr-Commit-Position: refs/heads/master@{#388736}

[modify] https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f/ui/aura/window_event_dispatcher.h
[modify] https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f/ui/events/event.cc
[modify] https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f/ui/events/event_unittest.cc
[modify] https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f/ui/views/mus/window_tree_host_mus.cc
[modify] https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Labels: screen
Cc: sadrul@chromium.org
Owner: riajiang@chromium.org
Status: Started (was: Assigned)
Blockedon: 646926
Blockedon: 646927
Blockedon: 646932
Blockedon: 646942
Components: Internals>MUS
Labels: Proj-Mustash
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f6a42748e827c3de474c76d6d2f56a78369d9c

commit 29f6a42748e827c3de474c76d6d2f56a78369d9c
Author: riajiang <riajiang@chromium.org>
Date: Mon Nov 21 20:09:31 2016

Add GetDisplayWithDisplayId to display::Screen.

BUG= 600815 
TEST=ash_unittests blimp_unittests app_shell_unittests
     display_unittests views_unittests

Review-Url: https://codereview.chromium.org/2361283002
Cr-Commit-Position: refs/heads/master@{#433618}

[modify] https://crrev.com/29f6a42748e827c3de474c76d6d2f56a78369d9c/ui/display/BUILD.gn
[modify] https://crrev.com/29f6a42748e827c3de474c76d6d2f56a78369d9c/ui/display/screen.cc
[modify] https://crrev.com/29f6a42748e827c3de474c76d6d2f56a78369d9c/ui/display/screen.h
[modify] https://crrev.com/29f6a42748e827c3de474c76d6d2f56a78369d9c/ui/display/screen_unittest.cc

Blockedon: 669371
Summary: High DPI support for mus (was: finish plumbing DPI in mus)
Changing the title to reflect that this is the tracking meta bug.
Labels: -mustash2 -mustash -screen Proj-Mustash-Milestone-Tadpole Proj-Mustash-Mus-WS
Components: -MUS>Phase>1
Labels: Pri-1
Blockedon: 659673
Blockedon: 675261

Comment 20 by sky@chromium.org, Jan 13 2017

Labels: mustash-1
Status: Fixed (was: Started)

Comment 22 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 24 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment