New issue
Advanced search Search tips

Issue 600813 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Apr 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 547073



Sign in to add a comment

Implement import of CA certificate.

Project Member Reported by dpa...@chromium.org, Apr 5 2016 
Currently only editing a CA certificate is implemented, but importing a new CA certificate is not. The same dialog can be used in both cases, but the dialog implementation needs to be slightly modified for each case.
edit_ca_dialog_old.png
52.6 KB View Download
import_ca_dialog_old.png
52.0 KB View Download

Comment 1 by dpa...@chromium.org, Apr 5 2016 

It seems to me that the new UI allows of re-using the exact same strings for both "edit" and "import" unlike the old UI (see attachment).
ca_dialog.png
35.3 KB View Download

Comment 2 by dpa...@chromium.org, Apr 5 2016

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/428e32f0d8e3abf983847314c1a82f1fe0ae935a

commit 428e32f0d8e3abf983847314c1a82f1fe0ae935a
Author: dpapad <dpapad@chromium.org>
Date: Thu Apr 07 00:38:35 2016

MD Settings: Certificate manager, implement importing CA certificate.

BUG= 600813 

Review URL: https://codereview.chromium.org/1863733003

Cr-Commit-Position: refs/heads/master@{#385605}

[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html
[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js
[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/browser/resources/settings/certificate_manager_page/certificate_list.js
[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js
[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js
[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/browser/resources/settings/certificate_manager_page/certificates_browser_proxy.js
[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.js
[modify] https://crrev.com/428e32f0d8e3abf983847314c1a82f1fe0ae935a/chrome/test/data/webui/settings/certificate_manager_page_test.js

Comment 4 by dpa...@chromium.org, Apr 7 2016

Status: Fixed (was: Started)
►

Sign in to add a comment