New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600807 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

BitmapUpload memory failure

Project Member Reported by rjkroege@chromium.org, Apr 5 2016

Issue description

When running on "pixel" mus, BitmapUploader appears to have a memory leak that ultimately brings down mus (and the entire device.)

Note that this blocks running software-composited Chrome in Mus+ash
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac

commit 7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac
Author: fsamuel <fsamuel@chromium.org>
Date: Thu Apr 07 04:16:48 2016

Make sure BitmapUploader Returns Resources

bitmap_uploader was inheriting from mus::mojom::SurfaceClient directly
instead of from WindowSurfaceClient. Unfortunately, ReturnResources
callbacks were going to the mus client lib and not to BitmapUploader and so
BitmapUploader never returned any resources.

This CL makes BitmapUploader a mus::WindowSurfaceClient and sets itself
as the client for the provided WindowSurface.

BUG= 600807 

Review URL: https://codereview.chromium.org/1864543004

Cr-Commit-Position: refs/heads/master@{#385655}

[modify] https://crrev.com/7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac/components/bitmap_uploader/bitmap_uploader.cc
[modify] https://crrev.com/7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac/components/bitmap_uploader/bitmap_uploader.h
[modify] https://crrev.com/7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac/components/mus/public/cpp/window_surface_client.h

Status: Fixed (was: Assigned)
I've tested that this patch fixes the issue on device as well as workstation. Marking as FIXED. 
Labels: VerifyIn-51
Status: Verified (was: Fixed)
Bulk verified
Components: Internals>Services>WindowService
Components: -MUS>Phase>1

Sign in to add a comment