New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600806 link

Starred by 1 user
Status: Fixed
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Closed: Apr 2016
Cc:
█ maxbogue@chromium.org
gogerald@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 599284



Sign in to add a comment

Fix SigninHelper to be used like an application singleton

Project Member Reported by wnwen@chromium.org, Apr 5 2016 
Eventually it should be merged back into SigninManager.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53511f941065102f8c8c5a476c5e4cc3770726ee

commit 53511f941065102f8c8c5a476c5e4cc3770726ee
Author: wnwen <wnwen@chromium.org>
Date: Mon Apr 18 14:53:10 2016

Refactor SigninHelper.

Rather than expose static methods and passing in the context of the
caller, since SigninHelper is designed to be used application-wide,
save the application context as a member variable instead.

Save the default shared preferences as a member variable, reducing
potential burden in the future.

BUG= 600806 , 599284 

Review URL: https://codereview.chromium.org/1860143003

Cr-Commit-Position: refs/heads/master@{#387905}

[modify] https://crrev.com/53511f941065102f8c8c5a476c5e4cc3770726ee/chrome/android/java/src/org/chromium/chrome/browser/services/AccountsChangedReceiver.java
[modify] https://crrev.com/53511f941065102f8c8c5a476c5e4cc3770726ee/chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java
[modify] https://crrev.com/53511f941065102f8c8c5a476c5e4cc3770726ee/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java
[modify] https://crrev.com/53511f941065102f8c8c5a476c5e4cc3770726ee/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java
[modify] https://crrev.com/53511f941065102f8c8c5a476c5e4cc3770726ee/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java

Comment 2 by wnwen@chromium.org, Apr 18 2016

Cc: maxbogue@chromium.org gogerald@chromium.org
Status: Fixed (was: Assigned)
Fixed the target refactoring, not planning on merging into SigninManager.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d491ec4d5956c60fbf72e8cb5d3b27c842f9e6b

commit 1d491ec4d5956c60fbf72e8cb5d3b27c842f9e6b
Author: wnwen <wnwen@chromium.org>
Date: Wed Apr 27 16:09:24 2016

Revert of
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2016

Labels: merge-merged-2718
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4506e91a9fd6a207329a63678ff1dfce01941e0b

commit 4506e91a9fd6a207329a63678ff1dfce01941e0b
Author: Alex Mineer <amineer@chromium.org>
Date: Wed Apr 27 17:04:29 2016

Revert of
►

Sign in to add a comment