New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600804 link

Starred by 2 users
Status: Fixed
Owner:
zhongyi@chromium.org
Closed: Apr 2016
Cc:
zhongyi@chromium.org
rch@chromium.org
b...@chromium.org
█ rtenneti@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 595938



Sign in to add a comment

Change server related dicts in HttpServerProperties to use SchemeHostPort as key

Project Member Reported by zhongyi@chromium.org, Apr 5 2016 
The http_server_properties_dict maintains several server-related dictionaries, e.g. SpdySettingMap, ServerNetworkStatsMap, etc. Those maps should use SchemeHostPort as the key so that we can apply to SHP key'ed Alt-Svc map. This will also involves disk data updates.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d4a55e707ebdd040bc9ce5bce45491efe84b97d

commit 3d4a55e707ebdd040bc9ce5bce45491efe84b97d
Author: zhongyi <zhongyi@chromium.org>
Date: Fri Apr 22 20:36:46 2016

Change SupportsSpdy dict, SpdySettingsMap, ServerNetworkStatsMap, AlternativeServiceMap and disk data to use scheme/host/port as keys. Previously we dropped down and ignored the scheme when processing those data.

BUG= 600804 

Review URL: https://codereview.chromium.org/1904483004

Cr-Commit-Position: refs/heads/master@{#389227}

[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/components/cronet/android/url_request_context_adapter.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/components/cronet/ios/cronet_environment.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/content/browser/loader/resource_scheduler.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/content/browser/loader/resource_scheduler_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/bidirectional_stream.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_network_transaction.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_server_properties.h
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_server_properties_impl.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_server_properties_impl.h
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_server_properties_impl_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_server_properties_manager.h
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_stream_factory.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_stream_factory.h
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_stream_factory_impl.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/quic/quic_network_transaction_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/quic/quic_stream_factory.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/quic/quic_stream_factory_test.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/spdy/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/spdy/spdy_session.cc
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/spdy/spdy_session.h
[modify] https://crrev.com/3d4a55e707ebdd040bc9ce5bce45491efe84b97d/net/spdy/spdy_session_unittest.cc

Comment 2 by zhongyi@chromium.org, Apr 22 2016

Status: Fixed (was: Started)

Comment 3 by zhongyi@chromium.org, Apr 22 2016

Cc: zhongyi@chromium.org
 Issue 595938  has been merged into this issue.
►

Sign in to add a comment