Lack of software compositor prevents ability to run browsertests in mash |
||||||||
Issue description
It would appear that the bots run browser_tests in a software only mode. This causes crashes in mus now as we hit an unimplemented else case in TopLevelDisplayClient. Specifically:
if (gpu_state->HardwareRenderingAvailable()) {
returns false. This means we can't run any browser_tests. It would be good if we do something to run at least one browser_test.
Here's the command that simulates what the bots run:
./tools/mb/mb.py run -j1000 -m chromium.mojo -b "Chromium Mojo Linux" //out/Debug2 browser_tests -- --run-in-mash --gtest_filter=BrowserTest.Title
,
Apr 7 2016
I'm seeing tests actually pass when I run this. out/Debug2/browser_tests -- --run-in-mash --gtest_filter=BrowserTest.Title --override-use-gl-with-osmesa-for-tests
,
Apr 7 2016
Awesome! I'll add that switch to the list of switches the bots run with.
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bacaa54b061311fa959a9763038a69e4df55b34d commit bacaa54b061311fa959a9763038a69e4df55b34d Author: sky <sky@chromium.org> Date: Thu Apr 07 21:34:19 2016 Add switch to mash's browser_tests This is needed for the time being as mus doesn't support a software compositor. BUG= 600802 , 594600 , 594600 TEST=none R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1869133002 Cr-Commit-Position: refs/heads/master@{#385876} [modify] https://crrev.com/bacaa54b061311fa959a9763038a69e4df55b34d/testing/buildbot/chromium.mojo.json [modify] https://crrev.com/bacaa54b061311fa959a9763038a69e4df55b34d/testing/buildbot/gn_isolate_map.pyl
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19679c126ac50358ace8db3cccb6b778e9340ab1 commit 19679c126ac50358ace8db3cccb6b778e9340ab1 Author: sky <sky@chromium.org> Date: Fri Apr 08 17:08:28 2016 Update browser_tests on chromium.mojo.fyi bot Apparently this is needed as the bot doesn't use swarming. BUG= 600802 , 594600 , 594600 TEST=none R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1873863003 Cr-Commit-Position: refs/heads/master@{#386107} [modify] https://crrev.com/19679c126ac50358ace8db3cccb6b778e9340ab1/testing/buildbot/chromium.mojo.json [modify] https://crrev.com/19679c126ac50358ace8db3cccb6b778e9340ab1/testing/buildbot/gn_isolate_map.pyl
,
Apr 18 2016
sky@ with the mesa flag, I think we agreed that this is lower priority? Adjust as needed. Given that CrOS doesn't do software compositing, this is not even needed for mus tadpole?
,
Apr 18 2016
,
Apr 18 2016
,
May 30 2016
,
Oct 4 2016
,
Jan 5 2017
I think we're good now.
,
Feb 26 2018
,
Feb 26 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by fsam...@chromium.org
, Apr 7 2016