New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600791 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools browser tests failing in Linux ChromeOS & Latest (Win, Mac & precise64) beta builds

Project Member Reported by sdantul...@chromium.org, Apr 5 2016

Issue description

DevTools browser tests failing in Linux ChromeOS Buildspec Tests builder

Link to Builder:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20ChromeOS%20Buildspec%20Tests/builds/601

Build: ChromeOS M50-BETA-9 (7978.43.0, 50.0.2661.65)

List of tests failing:
DevToolsPixelOutputTests.TestScreenshotRecording
DevToolsSanityTest.TestNetworkSize
DevToolsSanityTest.TestNetworkTiming
DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh
DevToolsSanityTest.TestDeviceEmulation
WorkerDevToolsSanityTest.InspectSharedWorker
DevToolsSanityTest.TestConsoleOnNavigateBack
DevToolsPixelOutputTests.TestLatencyInfoInstrumentation
DevToolsSanityTest.TestNetworkSyncSize
DevToolsSanityTest.TestNetworkRawHeadersText
DevToolsSanityTest.TestPauseWhenScriptIsRunning

 
Cc: mzheng@chromium.org
Owner: shchen@chromium.org
Status: Assigned (was: Untriaged)
+ shchen (who I think is gardener this week?)
Owner: achuith@chromium.org
achuith@ is the gardener this week.

Comment 5 Deleted

Please try to resolve this issue ASAP as we're very close to Desktop-M50 Stable candidate cut.
Labels: -ReleaseBlock-Stable
Removing Stable blocker label based on update #8 in  issue 599222 . But please try to fix ASAP.
Cc: kozyatinskiy@chromium.org dgozman@chromium.org pfeldman@chromium.org
Labels: -OS-Linux -OS-Windows -OS-Mac
sorry devtools folks - you've heard a lot from me this week.

Any idea why these browser tests are failing?
Cc: domlasko...@chromium.org
Status: WontFix (was: Assigned)
This is due to this merge: https://codereview.chromium.org/1855363002/. We didn't merge test changes as it was hard to do (different baselines). All tests should be passing on trunk bots.

I had an impression that nobody pays attention to test failures on the branch builds. Is that not a case anymore? Anyway, merging test fixes seems unnecessary.

#11: The Chrome OS TE team watches them quite closely, as we depend on browsertests in a branch build to supplement (and in many cases replace) manual testing of that official release candidate.
#11: Same is the case from "Chrome Desktop TE" as well.
Good to know! We'll be more careful with merging tests in the future.
What is the resolution of this bug? Have the test fixes been merged?
Cc: achuith@chromium.org
Labels: Merge-Request-50
Owner: dgozman@chromium.org
Status: Started (was: WontFix)
Would like to land a CL to disable these tests in M50. A merge of the fixes is not possible. 
This affects tests only - no production code.

Comment 18 by tin...@google.com, Apr 9 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M50, manual review required.
Cc: keta...@chromium.org
tinazh@ can you please approve for M50? We would like to get this bot green really quickly.

Comment 20 by tin...@google.com, Apr 11 2016

Hey, what's the proposed CL?

Comment 21 by ihf@chromium.org, Apr 11 2016

Cc: ihf@chromium.org
Here is the patch which disables a bunch of tests in 2661 branch: https://codereview.chromium.org/1879803002/
Labels: -Merge-Review-50 Merge-Approved-50
Approving merge to M50.
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 12 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c1086779e2dc5b1303595d86552448e5143428e

commit 0c1086779e2dc5b1303595d86552448e5143428e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Apr 12 18:29:02 2016

Disable a bunch of DevTools browsertests in 2661.

BUG= 600791 
R=achuith@chromium.org
TBR=achuith@chromium.org

Review URL: https://codereview.chromium.org/1879803002 .

Cr-Commit-Position: refs/branch-heads/2661@{#566}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/0c1086779e2dc5b1303595d86552448e5143428e/chrome/browser/devtools/devtools_sanity_browsertest.cc

Status: Fixed (was: Started)
Thank you Dmitry
Status: Verified (was: Fixed)
bulk verify (M50 clean up)

Sign in to add a comment