New issue
Advanced search Search tips

Issue 600789 link

Starred by 1 user
Status: Fixed
Owner:
scottmg@chromium.org
Closed: Apr 2016
Cc:
brucedaw...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 354261



Sign in to add a comment

GN fails to generate ninja files [Error 193]

Project Member Reported by gab@chromium.org, Apr 5 2016 
When I kick off my build @ r385195, I get (and I confirm that D:/src/chrome/src/buildtools/win/gn.exe exists):


D:\src\chrome\src>ninja -C out_gn\Release -k0 mini_installer
ninja: Entering directory `out_gn\Release'
[1/1] Regenerating ninja files
FAILED: D:/src/chrome/src/buildtools/win/gn.exe --root=D:/src/chrome/src -q gen //out_gn/Release/
Traceback (most recent call last):
  File "D:/src/chrome/src/remoting/host/installer/linux/build_deb.py", line 22, in <module>
    sys.exit(main())
  File "D:/src/chrome/src/remoting/host/installer/linux/build_deb.py", line 15, in main
    stdout=subprocess.PIPE)
  File "D:\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
  File "D:\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: D:/src/chrome/src/out_gn/Release/
Command: D:/depot_tools/python276_bin/python.exe -- D:/src/chrome/src/remoting/host/installer/linux/build_deb.py -p -s D:/src/chrome/src/
Returned 1.
ninja: error: rebuilding 'build.ninja': cannot make progress due to previous errors

Comment 1 by scottmg@chromium.org, Apr 5 2016 

Just posted a CL here: https://codereview.chromium.org/1864683002

Comment 2 by dpranke@chromium.org, Apr 5 2016

Blocking: 354261
Cc: brucedaw...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4203f09fa64c1c187a5e64c4650c1b27f995be8

commit e4203f09fa64c1c187a5e64c4650c1b27f995be8
Author: scottmg <scottmg@chromium.org>
Date: Tue Apr 05 19:55:01 2016

Don't run build_deb.py on Windows GN

Otherwise:

gn gen //out/Debug "--args=is_debug=true is_component_build=true enable_nacl=false is_chrome_branded=true symbol_level=2 target_cpu=\"x86\"" --check
Traceback (most recent call last):
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 22, in <module>
    sys.exit(main())
  File "d:/src/cr3/src/remoting/host/installer/linux/build_deb.py", line 15, in main
    stdout=subprocess.PIPE)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child
    startupinfo)
WindowsError: [Error 193] %1 is not a valid Win32 application
ERROR at //remoting/host/BUILD.gn:878:32: Script returned non-zero exit code.
          "$root_build_dir/" + exec_script(build_deb_script,
                               ^----------
Current dir: d:/src/cr3/src/out/Debug/
Command: d:/src/depot_tools/python276_bin/python.exe -- d:/src/cr3/src/remoting/host/installer/linux/build_deb.py -p -s d:/src/cr3/src/
Returned 1.

BUG= 600789 

Review URL: https://codereview.chromium.org/1864683002

Cr-Commit-Position: refs/heads/master@{#385265}

[modify] https://crrev.com/e4203f09fa64c1c187a5e64c4650c1b27f995be8/remoting/host/BUILD.gn

Comment 4 by scottmg@chromium.org, Apr 5 2016

Owner: scottmg@chromium.org
Status: Fixed (was: Untriaged)
This works for me now.
►

Sign in to add a comment