New issue
Advanced search Search tips

Issue 600766 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in blink::FontResource::beginLoadIfNeeded

Project Member Reported by ClusterFuzz, Apr 5 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6068414283513856

Fuzzer: inferno_webbot
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x0000000006e8
Crash State:
  blink::FontResource::beginLoadIfNeeded
  blink::DocumentLoader::startPreload
  blink::HTMLResourcePreloader::preload
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=144946:145047

Minimized Testcase (0.14 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv96Rck6bfsstva9BBHI1DYPiRgZadwuGUdE9swv2Dk-cYywyUCYX2_eaGgaRygiz9h-zEP5IcOiQONfACWqMf741go-ncQ5rIlkA6yvRY165ae3O7WTcQe8pBd6Cg7Q5wh90VxQjvLfWQuzPY9PAfKH6W9yUzQ
<script>
window.open("http://sra.org.uk");
window.open("http://articlecompilation.com");
window.location = "http://massagewkwk.com";</script></html>


Filer: ligimole

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>Fonts
Labels: M-50 Te-Logged
Owner: ksakamoto@chromium.org
Status: Assigned (was: Available)
Possible suspect as per Findit.

Author: ksakamoto
Component: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/6f0549c2726c0a730a03437dd7d7e157e3a42b65
Time: Fri Dec 04 10:16:56 2015
The CL last changed line 126 of file FontResource.cpp, which is stack frame 1.

Status: Started (was: Assigned)
Components: -Blink>Fonts Blink>WebFonts Blink>Loader
This is a regression by https://chromium.googlesource.com/chromium/src.git/+/b1ad8eab17e2d730f7eb112f644addb9b50842af
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1470667b97b1ce551060d595f0d41656526ad0f7

commit 1470667b97b1ce551060d595f0d41656526ad0f7
Author: ksakamoto <ksakamoto@chromium.org>
Date: Wed Apr 06 08:18:40 2016

Fix font preload crash

Adds null check for return value of FontResource::fetch(), as well as a
test exercising that code path.

BUG= 600766 

Review URL: https://codereview.chromium.org/1867493002

Cr-Commit-Position: refs/heads/master@{#385400}

[add] https://crrev.com/1470667b97b1ce551060d595f0d41656526ad0f7/third_party/WebKit/LayoutTests/http/tests/preload/preload-csp.html
[modify] https://crrev.com/1470667b97b1ce551060d595f0d41656526ad0f7/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Project Member

Comment 5 by ClusterFuzz, Apr 7 2016

ClusterFuzz has detected this issue as fixed in range 385386:385441.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6068414283513856

Fuzzer: inferno_webbot
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x0000000006e8
Crash State:
  blink::FontResource::beginLoadIfNeeded
  blink::DocumentLoader::startPreload
  blink::HTMLResourcePreloader::preload
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=144946:145047
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=385386:385441

Minimized Testcase (0.14 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv96Rck6bfsstva9BBHI1DYPiRgZadwuGUdE9swv2Dk-cYywyUCYX2_eaGgaRygiz9h-zEP5IcOiQONfACWqMf741go-ncQ5rIlkA6yvRY165ae3O7WTcQe8pBd6Cg7Q5wh90VxQjvLfWQuzPY9PAfKH6W9yUzQ
<script>
window.open("http://sra.org.uk");
window.open("http://articlecompilation.com");
window.location = "http://massagewkwk.com";</script></html>


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: Merge-Request-50
Status: Fixed (was: Started)
Fixed in Canary 51.0.2702.2. Requesting merge to M50.

Comment 7 by tin...@google.com, Apr 8 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M50, manual review required.

Comment 8 by tin...@google.com, Apr 8 2016

Labels: -Merge-Review-50 Merge-Approved-50
Merge approved for M50 (branch 2661). Pls go ahead merge.

Comment 9 Deleted

Please merge your change to M50 branch 2661 by 5:00 PM PST on April 11th,Monday to make into the desktop Stable final build cut. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 11 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bfbdd603d53b1e3287ba8b2c731bbf4aee7ece9

commit 3bfbdd603d53b1e3287ba8b2c731bbf4aee7ece9
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Apr 11 01:25:46 2016

Fix font preload crash

Adds null check for return value of FontResource::fetch(), as well as a
test exercising that code path.

BUG= 600766 

Review URL: https://codereview.chromium.org/1867493002

Cr-Commit-Position: refs/heads/master@{#385400}
(cherry picked from commit 1470667b97b1ce551060d595f0d41656526ad0f7)

Review URL: https://codereview.chromium.org/1874973002 .

Cr-Commit-Position: refs/branch-heads/2661@{#544}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[add] https://crrev.com/3bfbdd603d53b1e3287ba8b2c731bbf4aee7ece9/third_party/WebKit/LayoutTests/http/tests/preload/preload-csp.html
[modify] https://crrev.com/3bfbdd603d53b1e3287ba8b2c731bbf4aee7ece9/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Project Member

Comment 12 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment