New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600763 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Chromoting_Test_Driver logic to wait for the expected host to be online does not work

Project Member Reported by joedow@chromium.org, Apr 5 2016

Issue description

In order to increase the reliability of the CTD, logic was added to refetch the host list every few seconds for ~1 minute until we saw an online host with a matching name and jid.  This was to combat a backend propagation delay we had occasionally seen.

We are still seeing failures for this code on the waterfall though as the logic is not actually executed if the first check fails.  This logic needs to be fixed so the tool is more tolerant to potential propagation delays.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afb0295ebb94bbaf0b118c9fd364ca7434b27c78

commit afb0295ebb94bbaf0b118c9fd364ca7434b27c78
Author: joedow <joedow@chromium.org>
Date: Tue Apr 05 23:13:31 2016

Fixing the Chromoting Test Driver host online retry logic

In order to increase the reliability of the CTD, logic was added to
refetch the host list every few seconds for ~1 minute until we saw an
online host with a matching name and jid.  This was to combat a backend
propagation delay we had occasionally seen.

We are still seeing failures for this code on the waterfall though as
the logic is not actually executed if the first check fails.  This logic
needs to be fixed so the tool is more tolerant to potential propagation
delays.

The code that checks for the host being available did not have any unit
tests so I added those as well.

BUG= 600763 

Review URL: https://codereview.chromium.org/1864433005

Cr-Commit-Position: refs/heads/master@{#385319}

[modify] https://crrev.com/afb0295ebb94bbaf0b118c9fd364ca7434b27c78/remoting/test/chromoting_test_driver.cc
[modify] https://crrev.com/afb0295ebb94bbaf0b118c9fd364ca7434b27c78/remoting/test/chromoting_test_driver_environment.cc
[modify] https://crrev.com/afb0295ebb94bbaf0b118c9fd364ca7434b27c78/remoting/test/chromoting_test_driver_environment.h
[modify] https://crrev.com/afb0295ebb94bbaf0b118c9fd364ca7434b27c78/remoting/test/chromoting_test_driver_environment_unittest.cc

Owner: mmeade@chromium.org
Status: Fixed (was: Assigned)
Fix has been checked in and appears to be working (no failures and I've seen the retry logic kick in).  Resolving as fixed.

Sign in to add a comment