Olli can you add Intel suppressions for these tests in Windows/OpenGL?

Ah right, these are failing on my machine as well, but since the test just terminated silently I missed it. I uploaded a patch:

https://chromium-review.googlesource.com/#/c/337500

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/a1c917f2a41dfd212710627c61fcf525a313b623

commit a1c917f2a41dfd212710627c61fcf525a313b623
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Wed Apr 06 10:50:03 2016

Suppress samplers in structs test failures on Intel OpenGL

Some of the tests made to verify D3D implementation of samplers in
structs are failing on Intel's OpenGL drivers, so suppress the
failures.

Since the test was crashing in shader program setup, shader program
setup needs to be moved out of the SetUp() function of the texture
tests.

BUG= 600758 
TEST=angle_end2end_tests

Change-Id: I1b6e788d900425e914572d2a3d7ef1fc43146f50
Reviewed-on: https://chromium-review.googlesource.com/337500
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/a1c917f2a41dfd212710627c61fcf525a313b623/src/tests/gl_tests/TextureTest.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb8e85d5fa76718e228e17f05f93c6b9664c46f7

commit fb8e85d5fa76718e228e17f05f93c6b9664c46f7
Author: geofflang <geofflang@chromium.org>
Date: Tue Apr 12 19:37:31 2016

Roll ANGLE d4102f0..52b09c2

https://chromium.googlesource.com/angle/angle.git/+log/d4102f0..52b09c2

BUG= 349137 , 600758 

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1883643002

Cr-Commit-Position: refs/heads/master@{#386764}

[modify] https://crrev.com/fb8e85d5fa76718e228e17f05f93c6b9664c46f7/DEPS

The bug should be marked as available, as it's not a priority for NVIDIA to handle Intel-specific issues. If there's going to be a workaround in ANGLE I'd be okay with reviewing it though.

cc'ing Yang from the Intel team.

We will investigate these. Thanks for reporting!

Thanks Yang. I'll assign it to you in that case.

Changed owner to Jiawei, who is most familiar with this part and will investigate. 

Hi all,

I cannot find a Win7 Intel fyi bot now:
https://build.chromium.org/p/chromium.gpu.fyi/builders

Has it been removed?

Hi all,

I have verified these two cases can pass on Win7 with latest released Intel driver (15.45-4821 for Skylake, 15.40-4703 for Broadwell)

Can we close this bug?

Did we 

Can you lift the test suppressions from angle_end2end_tests? After that lands feel free to close this out.

I am going to close this bug since the test suppressions has been removed in:
https://chromium-review.googlesource.com/c/angle/angle/+/729549