Lock screen orientation/touchview layout issue |
|||||||||||||||
Issue descriptionChrome Version : 51.0.2696.0 OS Version: 8140.0.0 Board: veyron_minnie What steps will reproduce the problem? 1. Make the lock screen show up 2. Flip the keyboard backward (tablet mode), change the orientation of the device 3. Return the keyboard back in the clam-shell mode. You might need to repeat flipping and turning to repro this one. What is the expected result? Lock screen returns into its original state What happens instead of that? User pods are located at the wrong place - see the attached image
,
May 18 2016
,
May 24 2016
This definitely looks like crbug.com/361157 , but we need a way to reproduce this problem on a desktop to debug. Do you know of any hotkey to mimic tablet-laptop mode switching on a desktop build?
,
May 24 2016
Run chrome with the flag: --ash-enable-touch-view-testing Then press: control-alt-shift-F8 (shifts between ash and touchview) You can rotate using ctrl-refresh
,
May 24 2016
I wasn't able to reproduce... do you have reliable repro steps?
,
May 24 2016
You probably mean: "Then press: control-alt-shift-8 " This is not enough to reproduce the problem. Ctrl+Shift+F3 (rotate) rotates only clockwise. But "Return the keyboard back in the clam-shell mode." means counter-clockwize rotation. I'll try to find a device tomorrow.
,
May 24 2016
Ctrl-Alt-Shift-8 would return it to clam-shell mode (when pressed a second time) Still, getting a device is recommended.
,
May 25 2016
,
May 25 2016
You need to swipe into the screen from outside of screen. See video: https://goo.gl/photos/hx2uJu57n9f23SMN6
,
May 25 2016
I don't see any way to swipe on a desktop. But this is definitely reproducible on a device.
,
May 25 2016
Actually I should say many thanks to dzhioev@ for finding the way to reproduce the problem in #9.
,
May 25 2016
Also, as you can see on a video, swipe "inside the screen" is not enough. You need to swipe from outside.
,
May 26 2016
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcc752dc3c312176fc7dbc88a0b024139cb1d7c9 commit fcc752dc3c312176fc7dbc88a0b024139cb1d7c9 Author: alemate <alemate@chromium.org> Date: Thu May 26 05:07:51 2016 ChromeOS: disable ToggleMaximize for login and lock screen. ChromeOS login and lock screens must be always maximized even on touch devices. BUG= 600756 TEST=none Review-Url: https://codereview.chromium.org/2013963004 Cr-Commit-Position: refs/heads/master@{#396123} [modify] https://crrev.com/fcc752dc3c312176fc7dbc88a0b024139cb1d7c9/ash/wm/maximize_mode/maximize_mode_window_manager.cc
,
May 26 2016
,
Jun 3 2016
,
Jun 3 2016
,
Jun 3 2016
+abodenha@ Should I request merge to M51?
,
Jun 3 2016
Issue 617228 has been merged into this issue.
,
Jun 3 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/813f19edb50b28a14a0596fd22b64ebdf28e4703 commit 813f19edb50b28a14a0596fd22b64ebdf28e4703 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Jun 03 23:08:57 2016 ChromeOS: disable ToggleMaximize for login and lock screen. ChromeOS login and lock screens must be always maximized even on touch devices. BUG= 600756 TEST=none Review-Url: https://codereview.chromium.org/2013963004 Cr-Commit-Position: refs/heads/master@{#396123} (cherry picked from commit fcc752dc3c312176fc7dbc88a0b024139cb1d7c9) Review URL: https://codereview.chromium.org/2040493003 . Cr-Commit-Position: refs/branch-heads/2743@{#219} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/813f19edb50b28a14a0596fd22b64ebdf28e4703/ash/wm/maximize_mode/maximize_mode_window_manager.cc
,
Jun 6 2016
Assuming this has already been verified in ToT/52 merge approved for R51. Removing stable blocker since we already cut a stable, we can get this in second stable though.
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f7e55beeab37a0ef928dbee1caf30b3cab0fac6 commit 3f7e55beeab37a0ef928dbee1caf30b3cab0fac6 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Jun 06 21:50:00 2016 ChromeOS: disable ToggleMaximize for login and lock screen. ChromeOS login and lock screens must be always maximized even on touch devices. BUG= 600756 TEST=none Review-Url: https://codereview.chromium.org/2013963004 Cr-Commit-Position: refs/heads/master@{#396123} (cherry picked from commit fcc752dc3c312176fc7dbc88a0b024139cb1d7c9) Review URL: https://codereview.chromium.org/2041723005 . Cr-Commit-Position: refs/branch-heads/2704@{#709} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/3f7e55beeab37a0ef928dbee1caf30b3cab0fac6/ash/wm/maximize_mode/maximize_mode_window_manager.cc
,
Jun 6 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f7e55beeab37a0ef928dbee1caf30b3cab0fac6 commit 3f7e55beeab37a0ef928dbee1caf30b3cab0fac6 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Jun 06 21:50:00 2016 ChromeOS: disable ToggleMaximize for login and lock screen. ChromeOS login and lock screens must be always maximized even on touch devices. BUG= 600756 TEST=none Review-Url: https://codereview.chromium.org/2013963004 Cr-Commit-Position: refs/heads/master@{#396123} (cherry picked from commit fcc752dc3c312176fc7dbc88a0b024139cb1d7c9) Review URL: https://codereview.chromium.org/2041723005 . Cr-Commit-Position: refs/branch-heads/2704@{#709} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/3f7e55beeab37a0ef928dbee1caf30b3cab0fac6/ash/wm/maximize_mode/maximize_mode_window_manager.cc
,
Aug 29 2016
,
Sep 23 2016
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by abodenha@chromium.org
, Apr 5 2016Labels: ReleaseBlock-Stable
Owner: dzhioev@chromium.org
Status: Assigned (was: Untriaged)