New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600754 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Don't duplicate logic between PSS::CanSyncStart and StartupController::TryStart

Project Member Reported by maxbogue@chromium.org, Apr 5 2016 
ProfileSyncService should just pass a can_start callback into StartupController instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01eeca4d034210d0aa851531257e15208dda7a67

commit 01eeca4d034210d0aa851531257e15208dda7a67
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Apr 05 17:13:51 2016

[Sync] Inject startup dependencies into StartupController.

This forces StartupController to adhere to CanSyncStart instead of them
coincidentally sharing conditions. It also removes external dependencies
from StartupController and makes it cleaner to test.

This change also removes the Sync.RefreshTokenAvailable histogram,
which was no longer recorded as anything but true.

BUG= 600754 

Review URL: https://codereview.chromium.org/1858673002

Cr-Commit-Position: refs/heads/master@{#385202}

[modify] https://crrev.com/01eeca4d034210d0aa851531257e15208dda7a67/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/01eeca4d034210d0aa851531257e15208dda7a67/components/browser_sync/browser/profile_sync_service.h
[modify] https://crrev.com/01eeca4d034210d0aa851531257e15208dda7a67/components/sync_driver/startup_controller.cc
[modify] https://crrev.com/01eeca4d034210d0aa851531257e15208dda7a67/components/sync_driver/startup_controller.h
[modify] https://crrev.com/01eeca4d034210d0aa851531257e15208dda7a67/components/sync_driver/startup_controller_unittest.cc
[modify] https://crrev.com/01eeca4d034210d0aa851531257e15208dda7a67/tools/metrics/histograms/histograms.xml

Comment 2 by maxbogue@chromium.org, Apr 5 2016

Status: Fixed (was: Started)

Comment 3 by maxbogue@chromium.org, Oct 6 2016

Labels: Sync-Code-Health

Comment 4 by maxbogue@chromium.org, Oct 6 2016

Labels: -Sync-Code-Health Hotlist-CodeHealth
►

Sign in to add a comment