Issue metadata
Sign in to add a comment
|
bisect-builds.py for Chrome OS broken by ICU update |
||||||||||||||||||||||||
Issue descriptionbisect-builds.py is not currently working on Chrome OS. This change https://codereview.chromium.org/866473005/ made bisect for Chrome OS depend on third_party/icu/source/data/in/icudtl.dat. This file seems to have been removed by the latest update to ICU: https://chromium.googlesource.com/chromium/src/+/c49e2637e2e0e6a29968debcc92cc0fbe208e98d Without this file in this location, bisect fails. Further, when a copy of icudtl.dat is provided, bisect still only works correctly on builds of Chrome that use the matching version of icudtl.dat (this file changed with the ICU update). Specifically, the ICU update was revision #382201. When bisect launches specific builds, they will only work if they are provided their matching pre- or post-382201 copy of icudtl.dat; otherwise, the build silently fails to launch.
,
Apr 25 2016
,
Oct 31 2016
I didn't know that bisect relies on third_party/icu/source/data/in/icudtl.dat. Anyway, the file location moved to third_party/icu/common/icudtl.dat for non-Android. For Android, it always has been third_party/icu/android/icudtl.dat bisect tools should treat icudtl.dat as an integral part of a given build (like string resources or other resources).
,
Nov 1 2016
,
Nov 1 2016
I think the problem is that whatever script packages up the Chromium archived builds doesn't include icudtl.dat. I filed a bug to fix that underlying issue, but even once we fix it, we still have years worth of existing archived builds to deal with. Idea: 1. Fix the underlying issue, start shipping icudtl.dat 2. Add code to bisect-builds.py that knows the revisions where icudtl.dat moved or changed versions, and fetches the appropriate version based on the Chrome revision. That code would never have to change because going forward, icudtl.dat would just be included
,
Dec 9 2016
The switch from ICU 56 to 58 (https://codereview.chromium.org/2447513002, revision #429312) has caused another discontinuity. Bisects on revisions prior to #429312 require /src/third_party/icu/common/icudtl.dat to be the 56 version, and bisects after #429312 require the 58 version.
,
Dec 11 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, Apr 5 2016