New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600702 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

(CustomTabs) ClientManagerTest fails on Marshmallow testers

Project Member Reported by bauerb@chromium.org, Apr 5 2016

Issue description

ClientManagerTest.* has been failing on Marshmallow Tablet Tester since https://codereview.chromium.org/1832063002 (https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/3370).

Stack trace:
[FAIL] org.chromium.chrome.browser.customtabs.ClientManagerTest#testPredictionOutcomeNoPrediction:
java.lang.ExceptionInInitializerError
  at org.chromium.base.PathUtils.getDirectoryPath(PathUtils.java:141)
  at org.chromium.base.PathUtils.getDataDirectory(PathUtils.java:150)
  at org.chromium.base.library_loader.ModernLinker.loadLibraryImpl(ModernLinker.java:391)
  at org.chromium.base.library_loader.Linker.loadLibrary(Linker.java:570)
  at org.chromium.base.library_loader.LibraryLoader.loadLibrary(LibraryLoader.java:236)
  at org.chromium.base.library_loader.LibraryLoader.loadAlreadyLocked(LibraryLoader.java:281)
  at org.chromium.base.library_loader.LibraryLoader.ensureInitialized(LibraryLoader.java:140)
  at org.chromium.chrome.browser.customtabs.ClientManagerTest.setUp(ClientManagerTest.java:30)
  at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
  at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
  at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.os.AsyncTask.cancel(boolean)' on a null object reference
  at org.chromium.base.PathUtils.getOrComputeDirectoryPaths(PathUtils.java:69)
  at org.chromium.base.PathUtils.access$000(PathUtils.java:25)
  at org.chromium.base.PathUtils$Holder.<clinit>(PathUtils.java:55)
  ... 18 more

PathUtils.getDataDirectory() has an assert that setPrivateDataDirectorySuffix() should have been called, but asserts are no-ops at the moment, so it crashes later.

It seems that other tests that require the native library to be loaded derive from NativeLibraryTestBase to take care of this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25f9d3d669d28fe48444a5dd4314d2a0148c68e7

commit 25f9d3d669d28fe48444a5dd4314d2a0148c68e7
Author: bauerb <bauerb@chromium.org>
Date: Fri Apr 08 09:39:05 2016

[Custom Tabs] Make ClientManagerTest derive from NativeLibraryTestBase.

This takes care of everything that needs to happen to use the native library
(like initializing PathUtils).

BUG= 600702 

Review URL: https://codereview.chromium.org/1857223002

Cr-Commit-Position: refs/heads/master@{#386028}

[modify] https://crrev.com/25f9d3d669d28fe48444a5dd4314d2a0148c68e7/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java

Comment 2 by lizeb@chromium.org, Apr 8 2016

Issue 601190 has been merged into this issue.
Components: UI>Browser>Mobile>CustomTabs
Status: Fixed (was: Started)

Sign in to add a comment