New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600678 link

Starred by 1 user
Status: Fixed
Owner:
█ jbau...@chromium.org
not on Chrome anymore
Closed: May 2017
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted vertical line is seen on image while exiting from full screen mode in google.co.in

Reported by yfulgaon...@etouch.net, Apr 5 2016 
Chrome version : 51.0.2700.0 031aebddd2c595f9bcbf9c11457b5b23ced055fa-refs/heads/master@{#385057} 32/64 bit
OS : Windows (Win 7 aero enabled)

URL : https://www.google.co.in/search?q=gogi&oq=gogi&aqs=chrome..69i57j69i60j0l4.1110j0j7&sourceid=chrome&ie=UTF-8

Steps : 
1. Launch chrome, open NTP, click on 'Restore down' button and resize the browser window towards LHS. (Please refer an attachment)
2. Now click on 'Maximize' button and go to above URL.
3. Click on 'See photos' on the RHS and switch to Full Screen mode.
4. Now press F11 to exit from full screen mode and observe the image.

Actual : Unwanted vertical line is seen on image while switching into full screen mode.
Expected : Unwanted vertical line should not be seen.

This is a regression issue broken in 'M-51' and below is the manual regression and will soon update other info.
Actual_result.mp4
1.6 MB Download
Expected_result.mp4
1.4 MB Download

Comment 1 by yfulgaon...@etouch.net, Apr 5 2016

Labels: hasbisect
Owner: jbau...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression info.
Good Build : 51.0.2682.0   
Bad Build : 51.0.2683.0   

Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/763bbe944c22635b01caaa86cceb65a21fa1bb4c..9cc8ac7b7c2c95836b603afdf9ea6fa57a2b100c?pretty=fuller&n=10000

Suspecting : r 381933 from narrow bisect

@jbauman :  Could you please help to reassign if your change is not the cause for this issue

Note : Above issue is not seen on Mac and Linux info.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed

commit fab6a4eec6cb6b40e9931465bbc90d545a6d40ed
Author: jbauman <jbauman@chromium.org>
Date: Tue Apr 12 23:37:20 2016

Avoid restoring maximized window down when going fullscreen.

This was causing the window to temporarily appear at its restored size.
Making HWNDMessageHandler::IsMaximized return false when fullscreened is
another way of achieving the same goal - ensuring the task bar is
hidden.

BUG= 600678 
TEST=fullscreen/unfullscreen windows with/without themes on Win 7 without aero, win7 with aero, and win10.

Review URL: https://codereview.chromium.org/1859283003

Cr-Commit-Position: refs/heads/master@{#386864}

[modify] https://crrev.com/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed/ui/views/win/fullscreen_handler.cc
[modify] https://crrev.com/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed/ui/views/win/fullscreen_handler.h
[modify] https://crrev.com/fab6a4eec6cb6b40e9931465bbc90d545a6d40ed/ui/views/win/hwnd_message_handler.cc

Comment 3 by jbau...@chromium.org, May 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment