New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600661 link

Starred by 5 users
Status: Fixed
Owner:
█ ivoc@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
█ tnakamura@chromium.org
terelius@chromium.org
holmer@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

RTC event log capture does not start if started prior a peerconnection has been created.

Project Member Reported by jansson@chromium.org, Apr 5 2016 
Version: M49+
OS: Mac OS, Linux (most likely all)

What steps will reproduce the problem?
(1) Close all pages that has a peerconnection.
(2) Browse to chrome://webrtc-internals
(3) Expand create a dump
(4) Check the "Enable diagnostic packet and event recording" check box and click save
(5) Open a new page and navigate to https://appr.tc/?debug=loopback and join the room
(6) Wait a few secs then check if the event log file has been created in the location from step 4.

What is the expected output?
RTC event log file created

What do you see instead?
No file is created.

If the RTC event log capture is started during a call, it works fine.

Please use labels and text to provide additional information.

Comment 1 by jansson@chromium.org, Apr 5 2016 

Forgot to mention that the description on chrome://webrtc-internals of the feature states that this should work.

Comment 2 by holmer@chromium.org, Apr 5 2016

Cc: terelius@chromium.org holmer@chromium.org

Comment 3 by ivoc@chromium.org, Apr 5 2016

Status: Started (was: Assigned)
I have a CL up that should fix this problem (among other things): https://codereview.chromium.org/1855193002/ , but it's a big and complicated CL. I don't think it will be possible/desirable to land it before the cut, so I will make a small CL to change the description to match the current behavior as a temporary solution for M-51.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/283ce5457218fbd6d8634444374a7fd9c38935ef

commit 283ce5457218fbd6d8634444374a7fd9c38935ef
Author: ivoc <ivoc@chromium.org>
Date: Thu Apr 07 15:18:13 2016

Updated description of WebRTC event log functionality on the chrome://webrtc-internals page.

The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated.

BUG= chromium:600661 
NOTRY=true

Review URL: https://codereview.chromium.org/1863593002

Cr-Commit-Position: refs/heads/master@{#385760}

[modify] https://crrev.com/283ce5457218fbd6d8634444374a7fd9c38935ef/content/browser/resources/media/dump_creator.js
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf0887d3df989061ca653339e7affa8e49a3cfe6

commit cf0887d3df989061ca653339e7affa8e49a3cfe6
Author: ivoc <ivoc@chromium.org>
Date: Thu Jul 07 18:23:53 2016

Enable the WebRTC event log on PeerConnection instead of PeerConnectionFactory.

This allows simultaneous recording of event logs of multiple PeerConnections, each in a seperate file. The number of files is limited, as well as the size of each file. A callback handler is added to RenderProcessHost to allow code in chrome/ to register callbacks to implement the WebRTC event log functionality.

BUG= chromium:600661 , chromium:613499 , webrtc:4741 

Review-Url: https://codereview.chromium.org/1855193002
Cr-Commit-Position: refs/heads/master@{#404183}

[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/chrome/browser/media/webrtc_event_log_handler.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/chrome/browser/media/webrtc_event_log_handler.h
[add] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_eventlog_host.cc
[add] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_eventlog_host.h
[add] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_eventlog_host_unittest.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_internals.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_internals.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_internals_message_handler.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/media/peer_connection_tracker_host.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/media/peer_connection_tracker_host.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/resources/media/dump_creator.js
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/resources/media/webrtc_internals.css
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/common/media/aec_dump_messages.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/common/media/peer_connection_tracker_messages.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/content_browser.gypi
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/content_tests.gypi
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/public/browser/render_process_host.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/aec_dump_message_filter.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/aec_dump_message_filter.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/mock_peer_connection_impl.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/peer_connection_tracker.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/peer_connection_tracker.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/rtc_peer_connection_handler.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/webrtc/peer_connection_dependency_factory.h
[modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/render_thread_impl.cc

Comment 6 by ivoc@chromium.org, Jul 12 2016

Status: Fixed (was: Started)
This is now fixed, closing the issue.
►

Sign in to add a comment