New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600635 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove CQ timeline code

Project Member Reported by jochen@chromium.org, Apr 5 2016

Issue description

e.g. on 593793
https://chromium-cq-status.appspot.com/patch-timeline/1852393002/60001

I get this in the console:

Failed to load resource: the server responded with a status of 404 ()
https://chromium-cq-status.appspot.com/components/polymer/polymer.html Failed to load resource: the server responded with a status of 404 ()
https://chromium-cq-status.appspot.com/gl-matrix-min.js Failed to load resource: the server responded with a status of 404 ()
https://chromium-cq-status.appspot.com/d3.min.js Failed to load resource: the server responded with a status of 404 ()
math.html:31 Uncaught ReferenceError: vec2 is not defined
https://chromium-cq-status.appspot.com/jszip.min.js Failed to load resource: the server responded with a status of 404 ()
quad.html:15 Uncaught ReferenceError: vec2 is not defined
tab_view.html:103 Uncaught ReferenceError: Polymer is not defined
...
 

Comment 1 by adamk@chromium.org, May 10 2016

Cc: adamk@chromium.org
Components: Infra>CQ
Labels: -Pri-3 Pri-2
I'm still seeing this too, bumping priority and adding component since this seems 100% broken.
It fails to load /components/webcomponentsjs/webcomponents.js.
Looks like this is broken since version cb00036. Last working version is e03269c.
And culprit CL is https://codereview.chromium.org/1692743002.
Note that fix just reintroduces Polymer back. The timeline is still broken.
Cc: pgervais@chromium.org
I've tried bisecting history to find a version that was still working, but seems like timeline was broken since at least August last year. It could also be that it is broken because underlying data model has changed. The error message with my fix restoring Polymer is:

Import error
Error: Unrecognized color cq_build_attempt_running

I guess it has to do with the framework which draws the timeline. I am not familiar with it, but pgervais may be as the timeline was done by his intern. Looks like the color was introduced in https://codereview.chromium.org/1236243002, but I couldn't find any CL that actually defines it.

Comment 8 by jpar...@google.com, May 16 2016

Cc: jparent@chromium.org
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
Jochen, Adam -  this feature has been broken for months :(

Is this a feature that you do use/want to use?  If so, we'll look into how we can get an owner for it and proper monitoring so we don't break again.  Otherwise, if it is mostly unused, we'd like to remove it.

Comment 9 by adamk@chromium.org, May 16 2016

I only noticed when a new external contributor clicked on it and found a blank page. From my point of view removing it is fine (and in fact removing the link to it should be done ASAP).
Cc: -pgervais@chromium.org stip@chromium.org
Replacing myself with stip because he hosted the internship, not me.
Jochen, are you also fine with having timeline removed or do you think we should search for an owner for it?

Comment 12 by adamk@chromium.org, May 19 2016

Whatever the long-term decision here is, it seems like removing the link for now is the right next step to avoid further confusion.
Owner: serg...@chromium.org
I'm fine with having it removed
Owner: stip@chromium.org
I've removed the linkt. Mike, can you please remove the feature completely?
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/0085fac87e0b81dc20a23c3726d5b61b95d74d20

commit 0085fac87e0b81dc20a23c3726d5b61b95d74d20
Author: sergiyb <sergiyb@google.com>
Date: Fri Jun 03 16:21:10 2016

Owner: serg...@chromium.org
Status: Started (was: Assigned)
Summary: Remove CQ timeline code (was: cq timeline fails to load)
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/4a429a758183ec5e2fff1c0dff48b1eb31c7d211

commit 4a429a758183ec5e2fff1c0dff48b1eb31c7d211
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Thu Jun 09 09:53:24 2016

Removed timeline code

TBR=phajdan.jr@chromium.org
BUG= 600635 

Review URL: https://codereview.chromium.org/2056663002 .

[modify] https://crrev.com/4a429a758183ec5e2fff1c0dff48b1eb31c7d211/appengine/chromium_cq_status/README
[delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/builder_timeline_data.py
[delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/patch_timeline.py
[delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/patch_timeline_data.py
[delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/test/builder_timeline_data_test.py
[delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/test/patch_timeline_data_test.py
[modify] https://crrev.com/4a429a758183ec5e2fff1c0dff48b1eb31c7d211/appengine/chromium_cq_status/main.py
[modify] https://crrev.com/4a429a758183ec5e2fff1c0dff48b1eb31c7d211/appengine/chromium_cq_status/templates/index.html
[delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/templates/trace_viewer.html
[delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/third_party/catapult

Status: Fixed (was: Started)
P.S. Deployed new version of chromium-cq-status: 4a429a7.
Cc: sergeybe...@chromium.org dtu@chromium.org alancutter@chromium.org
 Issue 580605  has been merged into this issue.
 Issue 589478  has been merged into this issue.

Sign in to add a comment