Remove CQ timeline code |
|||||||||
Issue descriptione.g. on 593793 https://chromium-cq-status.appspot.com/patch-timeline/1852393002/60001 I get this in the console: Failed to load resource: the server responded with a status of 404 () https://chromium-cq-status.appspot.com/components/polymer/polymer.html Failed to load resource: the server responded with a status of 404 () https://chromium-cq-status.appspot.com/gl-matrix-min.js Failed to load resource: the server responded with a status of 404 () https://chromium-cq-status.appspot.com/d3.min.js Failed to load resource: the server responded with a status of 404 () math.html:31 Uncaught ReferenceError: vec2 is not defined https://chromium-cq-status.appspot.com/jszip.min.js Failed to load resource: the server responded with a status of 404 () quad.html:15 Uncaught ReferenceError: vec2 is not defined tab_view.html:103 Uncaught ReferenceError: Polymer is not defined ...
,
May 12 2016
It fails to load /components/webcomponentsjs/webcomponents.js. Looks like this is broken since version cb00036. Last working version is e03269c.
,
May 12 2016
And culprit CL is https://codereview.chromium.org/1692743002.
,
May 12 2016
And fix is https://codereview.chromium.org/1975773002.
,
May 12 2016
Note that fix just reintroduces Polymer back. The timeline is still broken.
,
May 12 2016
I've tried bisecting history to find a version that was still working, but seems like timeline was broken since at least August last year. It could also be that it is broken because underlying data model has changed. The error message with my fix restoring Polymer is: Import error Error: Unrecognized color cq_build_attempt_running I guess it has to do with the framework which draws the timeline. I am not familiar with it, but pgervais may be as the timeline was done by his intern. Looks like the color was introduced in https://codereview.chromium.org/1236243002, but I couldn't find any CL that actually defines it.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/05106f0a0414583fccd11050a565a11e8f660384 commit 05106f0a0414583fccd11050a565a11e8f660384 Author: sergiyb <sergiyb@chromium.org> Date: Thu May 12 17:15:25 2016 Remove rule that removed polymer code R=phajdan.jr@chromium.org BUG= 600635 Review-Url: https://codereview.chromium.org/1975773002 [modify] https://crrev.com/05106f0a0414583fccd11050a565a11e8f660384/appengine/chromium_cq_status/app.yaml
,
May 16 2016
Jochen, Adam - this feature has been broken for months :( Is this a feature that you do use/want to use? If so, we'll look into how we can get an owner for it and proper monitoring so we don't break again. Otherwise, if it is mostly unused, we'd like to remove it.
,
May 16 2016
I only noticed when a new external contributor clicked on it and found a blank page. From my point of view removing it is fine (and in fact removing the link to it should be done ASAP).
,
May 16 2016
Replacing myself with stip because he hosted the internship, not me.
,
May 19 2016
Jochen, are you also fine with having timeline removed or do you think we should search for an owner for it?
,
May 19 2016
Whatever the long-term decision here is, it seems like removing the link for now is the right next step to avoid further confusion.
,
May 30 2016
I'm fine with having it removed
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/a6513553588682af329efd2b1909890776d2176e commit a6513553588682af329efd2b1909890776d2176e Author: sergiyb <sergiyb@chromium.org> Date: Tue May 31 06:58:12 2016 Remove link to timeline view as it's broken and unowned R=phajdan.jr@chromium.org BUG= 600635 Review-Url: https://codereview.chromium.org/2024053002 [modify] https://crrev.com/a6513553588682af329efd2b1909890776d2176e/appengine/chromium_cq_status/templates/patch_status.html
,
May 31 2016
I've removed the linkt. Mike, can you please remove the feature completely?
,
Jun 3 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/0085fac87e0b81dc20a23c3726d5b61b95d74d20 commit 0085fac87e0b81dc20a23c3726d5b61b95d74d20 Author: sergiyb <sergiyb@google.com> Date: Fri Jun 03 16:21:10 2016
,
Jun 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/4b2fff9be64093df864b911017d5b362d1794d69 commit 4b2fff9be64093df864b911017d5b362d1794d69 Author: sergiyb <sergiyb@chromium.org> Date: Tue Jun 07 16:42:20 2016 Remove [timeline] from the list of raw CQ events R=tandrii@chromium.org BUG= 600635 Review-Url: https://codereview.chromium.org/2040253002 [modify] https://crrev.com/4b2fff9be64093df864b911017d5b362d1794d69/appengine/chromium_cq_status/js/recent.js
,
Jun 9 2016
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/4a429a758183ec5e2fff1c0dff48b1eb31c7d211 commit 4a429a758183ec5e2fff1c0dff48b1eb31c7d211 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Thu Jun 09 09:53:24 2016 Removed timeline code TBR=phajdan.jr@chromium.org BUG= 600635 Review URL: https://codereview.chromium.org/2056663002 . [modify] https://crrev.com/4a429a758183ec5e2fff1c0dff48b1eb31c7d211/appengine/chromium_cq_status/README [delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/builder_timeline_data.py [delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/patch_timeline.py [delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/patch_timeline_data.py [delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/test/builder_timeline_data_test.py [delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/handlers/test/patch_timeline_data_test.py [modify] https://crrev.com/4a429a758183ec5e2fff1c0dff48b1eb31c7d211/appengine/chromium_cq_status/main.py [modify] https://crrev.com/4a429a758183ec5e2fff1c0dff48b1eb31c7d211/appengine/chromium_cq_status/templates/index.html [delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/templates/trace_viewer.html [delete] https://crrev.com/a404cc67fbb82decf0c7b5391cd9924136c5f7f3/appengine/chromium_cq_status/third_party/catapult
,
Jun 9 2016
,
Jun 9 2016
P.S. Deployed new version of chromium-cq-status: 4a429a7.
,
Jul 6 2016
Issue 580605 has been merged into this issue.
,
Jul 6 2016
Issue 589478 has been merged into this issue. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by adamk@chromium.org
, May 10 2016Components: Infra>CQ
Labels: -Pri-3 Pri-2