New issue
Advanced search Search tips

Issue 600631 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Rename inDocument() to inShadowIncludingDocument()

Project Member Reported by yuzus@chromium.org, Apr 5 2016

Issue description

What current inDocument() does and its name do not match, so rename the function to the appropriate name, which is inShadowIncludingDocument().

 

Comment 1 by yuzus@chromium.org, Apr 5 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40fbf8f4d6a7af7041d45319d92312755aa28977

commit 40fbf8f4d6a7af7041d45319d92312755aa28977
Author: yuzus <yuzus@chromium.org>
Date: Thu Apr 07 06:41:20 2016

Rename inDocument() to inShadowIncludingDocument()

This CL renames inDocument() to inShadowIncludingDocument(), which better matches what the function does, and makes it consistent with spec terminology.
See the description of the term "Shadow Including Document" in the spec: https://dom.spec.whatwg.org/#in-a-shadow-including-document

BUG= 600631 

Review URL: https://codereview.chromium.org/1858163002

Cr-Commit-Position: refs/heads/master@{#385680}

[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/Range.h
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/SelectorQuery.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/StyleElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/custom/CustomElementCallbackInvocation.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/EphemeralRange.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/PendingSelection.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/Position.h
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/FormAssociatedElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLBaseElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLMapElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLScriptElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLStyleElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/imports/LinkImport.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/page/PointerLockController.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGImageElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGMPathElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/xml/XPathPath.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/web/RotationViewportAnchor.cpp
[modify] https://crrev.com/40fbf8f4d6a7af7041d45319d92312755aa28977/third_party/WebKit/Source/web/TextFinder.cpp

Comment 3 by yuzus@chromium.org, Apr 7 2016

Status: Fixed (was: Started)

Sign in to add a comment