New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Download Protection: SPARSEBUNDLE and SPARSEIMAGE files not checked on Mac OS X

Reported by resea...@nightwatchcybersecurity.com, Apr 5 2016

Issue description

VERSION
Chrome Version: 49.0.2623.87 Official Build
Operating System: Mac OS X El Capitan, version 10.11.3

REPRODUCTION CASE
SPARSEBUNDLE and SPARSEIMAGE files are not checked by download protection on Mac OS. Problem is that you can take any DMG file and renamed it, and serve it that way. Mac OS will treat both the same. To replicate this issue, take any DMG file, stick it on a web server, and rename to an .SPARSEIMAGE or .SPARSEBUNDLE. Then download on Mac and double click. It will act the same way as a DMG.

We can try to provide a patch.

Same behavior as 
https://bugs.chromium.org/p/chromium/issues/detail?id=596354 but found later on
 
This also affects the following extensions:
CDR
DMGPART
DVDR
DART
DC42
DISKCOPY42
IMGPART
NDIF
UDIF
Cc: rsesek@chromium.org
Labels: Pri-2
Owner: jialiul@chromium.org
jialiul -- Can you confirm try these and confirm this behavior?  Then we should treat these like DMGs and report+parse them.
FYI real .sparsebundle files cannot be directly downloaded from the web, since they are directories (.sparseimage files are plain files). Neither are currently supported by the DMG analyzer within Chromium, though. But renaming a .dmg to one of those extensions would trigger DiskUtility to open it regardless of the extension.
Confirmed. Unfortunately, these types are not in our dangerous file type list, and they can be opened the same way as dmg. 
If we wanted to avoid using extension lists for this, it is possible to query the system for what application will open the file. That can be done with -[NSWorkspace URLForApplicationToOpenURL:].
In addition to the extensions in comment, also .TOAST
Labels: -Restrict-View-SecurityTeam Restrict-View-Google
Status: Started (was: New)
Labels: Merge-Request-50
Merge request due to security implication. Thanks!

Comment 11 by vakh@chromium.org, Apr 18 2016

research@nightwatchcybersecurity.com: Thanks for reporting the issue. As confirmed by jialiul@, we can reproduce this issue locally.

I'll investigate whether it falls within the guidelines of the VRP program (it most likely does) and will update the issue shortly thereafter.

Comment 12 by vakh@chromium.org, Apr 18 2016

I can confirm that the issue does indeed fall within the guidelines of the Download Protection bypass VRP. Sending to the panel for reward review.

Comment 13 by vakh@chromium.org, Apr 18 2016

Labels: reward-to-sb-panel
Labels: OS-Mac

Comment 15 by tin...@google.com, Apr 19 2016

Pls confirm the change has baked in canary and verified safe? Thanks.

Comment 16 by tin...@google.com, Apr 19 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M50), manual review required.

Comment 17 by tin...@google.com, Apr 19 2016

jialiul@ is waiting for canary to ramp up a little more to get meaningful data from UMA, we chatted and agreed not to include in this week's M50 stable refresh but potential future ones.
tinazh@, I has verified this change in canary. Request permission to merge into later M50 stable refresh. Thanks! 
Status: Fixed (was: Started)
Cc: tinazh@chromium.org
Labels: -Merge-Review-50 Merge-Approved-50
Approving merge M50 branch 2661 based on Comment #17 & #18.

Comment 22 by vakh@chromium.org, Apr 25 2016

Labels: reward-6000 reward-unpaid

Comment 23 by vakh@chromium.org, Apr 25 2016

Labels: -reward-to-sb-panel
Labels: -reward-unpaid reward-inprocess
Thanks again for your report.

Someone from our finance team should get in contact within 7 days to collect payment details. If that doesn't happen, please contact me directly at timwillis@ or update this bug.
Labels: -Restrict-View-Google
Cc: ya...@nightwatchcybersecurity.com

Comment 27 by vakh@chromium.org, Mar 10 2017

Labels: Restrict-View-SecurityTeam
For all Download Protection VRP bugs: removing label Restrict-View-Google and adding Restrict-View-SecurityTeam instead.
Project Member

Comment 28 by sheriffbot@chromium.org, Mar 11 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment