Messaging when rejecting a CL for new, failing tests is confusing |
|||||||||
Issue descriptionExample: https://codereview.chromium.org/1854003004/#ps40001 This CL adds some new tests that fail on windows. However, the tryjob's ultimate result is "TEST RESULTS WERE INVALID", which is confusing (a better message might be something like "NEWLY ADDED TESTS ARE FAILING", or something). I think this could be detected by asking the without-patch test harness if it knows about the failing tests.
,
Apr 6 2016
,
Apr 26 2016
,
Jun 3 2016
,
Aug 3 2016
,
Aug 13 2016
,
Jun 13 2017
,
Jun 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2018
Archiving as very old and inactive. I believe CQ got a major facelift since then, and hopefully the messages are now better. If not, please reopen and provide another more recent example. Thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by iannu...@google.com
, Apr 5 2016