Presubmit checks broken on Windows |
||
Issue descriptionPresubmit checks seem to be broken on Windows. Trying to upload https://codereview.chromium.org/1852393002 results in the following: D:\src\chrome\src>git cl upload Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit upload checks ... checking owners took a long time: 581ms 'build' is not recognized as an internal or external command, operable program or batch file. Done processing D:\src\chrome\src\chrome\app\chrome_crash_reporter_client.cc ** Presubmit ERRORS ** Error running: build/print_python_deps.py --root tools/swarming_client --output build/secondary/tools/swarming_client/isolate.pydeps --whitelist tools/swarming_client/third_party tools/swarming_client /isolate.py --output "" Presubmit checks took 13.3s to calculate. agrieve@, I am pretty sure this was caused by https://chromium.googlesource.com/chromium/src.git/+/f32bcc73dfef6e5d282c6b37fd3e25da441a0c94 . Can you please investigate?
,
Apr 21 2016
I haven't tried uploading a CL from Windows for a while. Appreciate your looking into it.
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb9c5b47a31a4a40eb2d442e2f1f1a4dac752a81 commit bb9c5b47a31a4a40eb2d442e2f1f1a4dac752a81 Author: agrieve <agrieve@chromium.org> Date: Fri Apr 22 15:13:00 2016 Skip the .pydeps presubmit check on windows BUG= 600604 Review URL: https://codereview.chromium.org/1911813002 Cr-Commit-Position: refs/heads/master@{#389109} [modify] https://crrev.com/bb9c5b47a31a4a40eb2d442e2f1f1a4dac752a81/PRESUBMIT.py [modify] https://crrev.com/bb9c5b47a31a4a40eb2d442e2f1f1a4dac752a81/PRESUBMIT_test_mocks.py
,
Apr 25 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by agrieve@chromium.org
, Apr 21 2016