Issue 600588 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	dbeam@chromium.org
Closed:	Nov 2016
Cc:	█ scottchen@chromium.org dpa...@chromium.org
Components:	UI>Settings
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Proj-MaterialDesign-WebUI Hotlist-MD-Settings-General

Blocking:
issue 425627

MD Settings: Move custom element CSS to <style> tags

Project Member Reported by michae...@chromium.org, Apr 5 2016

Issue description

Polymer deprecated <link rel="import" type="css"> external stylesheets[1].

MD Settings should switch to <style> tags in HTML, which probably has performance advantages such as not loading duplicate stylesheets.

(Other Polymer WebUI should probably switch too.)

[1] https://www.polymer-project.org/1.0/docs/devguide/styling.html#external-stylesheets

Comment 1 by dbeam@chromium.org, Apr 5 2016

Cc: dbeam@chromium.org
Owner: ----

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bf849aaf8ed65dd27cfdf8411b8b874d8e37af5

commit 1bf849aaf8ed65dd27cfdf8411b8b874d8e37af5
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Apr 05 02:19:55 2016

MD Settings: Move settings-animated-pages CSS to HTML

BUG= 600588 
R=dpapad@chromium.org

Review URL: https://codereview.chromium.org/1858903002

Cr-Commit-Position: refs/heads/master@{#385088}

[delete] https://crrev.com/ba9fd2175b03955c52a60f3bd1ea95313948afe4/chrome/browser/resources/settings/settings_page/settings_animated_pages.css
[modify] https://crrev.com/1bf849aaf8ed65dd27cfdf8411b8b874d8e37af5/chrome/browser/resources/settings/settings_page/settings_animated_pages.html
[modify] https://crrev.com/1bf849aaf8ed65dd27cfdf8411b8b874d8e37af5/chrome/browser/resources/settings/settings_resources.grd

Comment 3 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-General

Comment 4 by dbeam@chromium.org, Aug 8 2016

can we call this fixed now?

Comment 5 by dpa...@chromium.org, Nov 3 2016

Cc: scottchen@chromium.org

FWIW, there is a single CSS file left under chrome/browser/settings/

search_engines_page/search_engine_entry.css

Comment 6 by dbeam@chromium.org, Nov 3 2016

Owner: dbeam@chromium.org
Status: Started (was: Available)

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48a68ee1b819983e6849dbccadf33b7248db8c1

commit c48a68ee1b819983e6849dbccadf33b7248db8c1
Author: dbeam <dbeam@chromium.org>
Date: Sat Nov 05 00:27:38 2016

MD Settings: convert last .css file to style module

R=dpapad@chromium.org
BUG= 600588 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2464393003
Cr-Commit-Position: refs/heads/master@{#430085}

[modify] https://crrev.com/c48a68ee1b819983e6849dbccadf33b7248db8c1/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[delete] https://crrev.com/a3c7d6d6c5556377d9966a3f2a8fcb36bb972bc0/chrome/browser/resources/settings/search_engines_page/search_engine_entry.css
[modify] https://crrev.com/c48a68ee1b819983e6849dbccadf33b7248db8c1/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[add] https://crrev.com/c48a68ee1b819983e6849dbccadf33b7248db8c1/chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html
[modify] https://crrev.com/c48a68ee1b819983e6849dbccadf33b7248db8c1/chrome/browser/resources/settings/settings_resources.grd

Comment 8 by dbeam@chromium.org, Nov 5 2016

Cc: -dbeam@chromium.org
Status: Fixed (was: Started)

►

Issue 600588 link

Issue metadata

MD Settings: Move custom element CSS to <style> tags

Issue description

Comment 1 by dbeam@chromium.org, Apr 5 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 5 2016

Comment 2 Deleted

Comment 3 by tbuck...@chromium.org, May 24 2016

Comment 3 Deleted

Comment 4 by dbeam@chromium.org, Aug 8 2016

Comment 4 Deleted

Comment 5 by dpa...@chromium.org, Nov 3 2016

Comment 5 Deleted

Comment 6 by dbeam@chromium.org, Nov 3 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Nov 5 2016

Comment 7 Deleted

Comment 8 by dbeam@chromium.org, Nov 5 2016

Comment 8 Deleted

Sign in to add a comment