New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600544 link

Starred by 1 user
Status: Fixed
Owner:
mattreynolds@chromium.org
Closed: Apr 2016
Cc:
█ animohan@chromium.org
█ scottj@chromium.org
█ mmo...@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Increase size of icons in Physical Web list from 16dp to 32dp

Project Member Reported by scottj@chromium.org, Apr 4 2016 
Current version has icons that are a bit too small. As many websites now have larger favicons and/or other tags with larger icons, it would would allow better, faster, and more branded scanning of the results by making them larger.

Note: This is still assuming the PWS returns a single icon resource. There is a separate bug where the PWS will return a better (larger) icon if it's available.

Attached is a new mock showing these larger icons. Note the the text of each item must be shifted over 16dp to make room (and therefore reduce their width by 16dp as well)

Comment 1 by mattreyn...@google.com, Apr 5 2016 

I've attached two screenshots showing the icons at 32dp and 48dp.  IMO 32dp looks good, 48dp is probably too large given how common low-res favicons are.
Screenshot_20160404-171245.png
177 KB View Download
Screenshot_20160404-174812.png
195 KB View Download

Comment 2 by mmo...@chromium.org, Apr 5 2016 

Sounds good.  32 looks significantly better.

Comment 3 by scottj@chromium.org, Apr 5 2016 

deleted my mock as Matt's mock's are the more accurate ones to compare against. Also agree that 32x32 looks better

Comment 4 by mattreynolds@chromium.org, Apr 5 2016

Owner: mattreynolds@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c26514ab2830eab67aa7558b742b3516ebb61f6

commit 3c26514ab2830eab67aa7558b742b3516ebb61f6
Author: mattreynolds <mattreynolds@chromium.org>
Date: Tue Apr 05 19:07:28 2016

Increase favicon size in Physical Web nearby URLs list from 16dp to 32dp

BUG= 600544 

Review URL: https://codereview.chromium.org/1864653002

Cr-Commit-Position: refs/heads/master@{#385248}

[modify] https://crrev.com/3c26514ab2830eab67aa7558b742b3516ebb61f6/chrome/android/java/res/layout/physical_web_list_item_nearby_url.xml
►

Sign in to add a comment