New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600520 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Decorations do not retain their gray backgrounds when clicked to display their bubbles

Project Member Reported by shrike@chromium.org, Apr 4 2016 
OS: 10.11

What steps will reproduce the problem?
(1) Activate Material Design mode
(2) Create a new browser window
(3) Press Cmd = to increase the zoom level
(4) Let the zoom bubble disappear
(5) Click the zoom decoration in the omnibox

What is the expected output?
The zoom decoration should retain its pressed look (magnifier with gray rounded rect background).

What do you see instead?
There is no background behind the zoom decoration icon.

This bug is not specific to the zoom decoration - it applies to all decorations that display bubbles when clicked.

Comment 1 by shrike@chromium.org, Apr 14 2016

Cc: shrike@chromium.org
Owner: sgabr...@chromium.org
sgabriel@ - should the zoom icon have a pressed-state background in this case? I see that buttons in the toolbar do but it seems like Omnibox decorations may not.

Comment 2 by sgabr...@chromium.org, Apr 14 2016 

To be consistent with how the other icons behave, yes.
omnibox icons do have pressed state background. This background also applies when you use keyboard shortcuts.

Comment 3 by shrike@chromium.org, Apr 14 2016

Cc: -shrike@chromium.org sgabr...@chromium.org
Owner: shrike@chromium.org
OK, thank you.

Comment 4 by shrike@chromium.org, May 19 2016

Blocking: -547953
It looks like the place to draw it is in ImageDecoration::DrawInFrame(), based on whether or not the bubble is visible. That bit of state does not appear to currently be kept. The decoration also needs to be redrawn when clicked on, and when its bubble goes away.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 14 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by shrike@chromium.org, Oct 17 2016

Labels: M-56
Owner: spqc...@chromium.org
spqchan@ - I think you are directly addressing this bug with the changes you are making to omnibox decorations?

Comment 8 by spqc...@chromium.org, Oct 17 2016 

yep, bingo

Comment 9 by spqc...@chromium.org, May 23 2017 

This is pretty much implemented. The one that's left is the zoom icon, for some reason the change for that got reverted

Comment 10 by spqc...@chromium.org, May 23 2017

Status: Fixed (was: Assigned)
Never mind, it looks like the zoom icon issue is Secondary MD UI exclusive. I created a separate issue for that
►

Sign in to add a comment